Update Playwright to v1.27 #45193
Merged
Update Playwright to v1.27 #45193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
|
Size Change: +78 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
@kevin940726 Is there anything we need to do to migrate to the stable version of this API? |
kevin940726
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Awesome! Could you also update the Best Practices guide to include a link of the documentation of these RTL selectors?
Is there anything we need to do to migrate to the stable version of this API?
We're already using the stable API, only that it's string-based now. We could decide to opt-in to these new APIs or allow both usages. I don't really have a preference. My only recommendation is to stop using CSS selectors 😅
|
I will update the Best Practices docs as well. I think we should mention new APIs in the docs but have no hard rule about the usage. As you said, @kevin940726, we should only care that people are using good locators 😄 I also like the "Which query should I use?" page from Testing Library. Would it make sense to have something similar in our docs? |
|
Well, on second thought, I think I like the string-based role selectors more. Some RTL selectors ( But that's just my opinion 😆 , let's just allow both and stop the bikeshedding 😂 . |
|
Just so we're on the same page, this is what we call a string-based locator, correct?
100%. I will just mention both options and try to emphasize role base selector. |
Yep, that's what I call a string-based locator 😅 |
Mamaduka
force-pushed
the
update/playwright-1-27
branch
from
de10a2c
to
32d9039
Compare
|
@kevin940726, Since we always prefer role selectors, I just mentioned the new short-form API alongside the string-based locator in the README. |
kevin940726
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upgrade
@playwright/testto v1.27.1.Why?
v1.27 introduced a new locator APIs inspired by Testing Library. This would make it easier for folks to use locators, especially now that unit tests are fully migrated to RTL.
New APIs:
For more details, see the release page: https://github.com/microsoft/playwright/releases/tag/v1.27.0
Testing Instructions
CI should pass.