WIP - Migrate navigation block e2e tests to playwright #42695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
talldan
force-pushed
the
migrate/navigation-block-e2e-tests-to-playwright
branch
from
5f4e0e4
to
bb6c840
Compare
|
Great to see these being migrated. I'm not sure about the user login stuff. Need to look at what Puppeteer does. I'll try and contribute here but I have a lot of AFK in the next month. |
talldan
commented
Aug 10, 2022
|
|
||
| async function deleteUser( this: RequestUtils, username: string ) { | ||
| await this.rest( { | ||
| path: `wp/v2/users/${ username }`, |
There was a problem hiding this comment.
I think a user id is needed to delete a user, in manual testing a username can't be used like this.
25 tasks
|
@talldan Just so you know there is work underway to rewrite the tests to make them simpler and easy to reason about. These will be in Playwright. Your work here is providing ample inspiration so thank you 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Something I started on a couple of months ago but haven't had time to finish is migrating nav block e2e tests to playright.
I thought I'd push this PR in case anyone wants to contribute to the effort.
I'd completely reorganised the test cases. The old test case description is above every new test case in a comment - something I did during development to make sure every test case was accounted for.
IIRC, I'd gotten as far as one of the tests that require logging in as a test user, but the
requestUtils.login( user )wasn't working as it should.