Typography: add explicit bypass for fluid font size calculation #42757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Enhancement
|
Size Change: +7 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
scruffian
reviewed
Jul 28, 2022
…y to bypass fluid calculations for a specific font.
ramonjd
force-pushed
the
update/fluid-font-size-bypass-flag
branch
from
12ceb4f
to
e3ac832
Compare
matiasbenedetto
added a commit
to Automattic/themes
that referenced
this pull request
Jul 29, 2022
madhusudhand
pushed a commit
to Automattic/themes
that referenced
this pull request
Aug 5, 2022
madhusudhand
added a commit
to Automattic/themes
that referenced
this pull request
Aug 5, 2022
* Club: implementing fluid typography * fixing name mistake * Club: adding link styles. Co-authored-by: madhusudhand <madhusudhan.dollu@gmail.com> * Club: line-heigth change * Club: theme.json workaround to stylize link inside post-date block * Club: adding letter spacing * Club: implemeting explicit bypass for fluid font size calculation WordPress/gutenberg#42757 * Club: tweaking font sizes * Club: headings font weight * Club: font size tweaks * Club: moving font sizes definition away from default font sizes array. The itention is to keep in the fontSizes array just the sizes defined in the default Gutenberg theme.json file: https://github.com/WordPress/gutenberg/blob/640856bce02f37173f53ad664b3796a3eeb687e5/lib/compat/wordpress-6.1/theme.json#L282-L306 * move letter spacing to heading Co-authored-by: madhusudhand <madhusudhan.dollu@gmail.com>
oandregal
added
the
[Feature] Design Tools
|
Added label for changelog. |
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #42698
Related to:
What?
Allowing for an explicit
falsevalue in the fluid font size property to bypass fluid calculations for a specific font.Why?
So that theme authors can select which font sizes receive fluid treatment when
settings.typography.fluidis set totrue.How?
Checking for
"fluid" === falsebefore performing fluid font size calculations and, if found, returning the static font size.Testing Instructions
Enable fluid typography.
Add some font sizes to your theme.json (see example theme.json below)
For one or two sizes, set
fluidtofalse. E.g.,{ "size": "2.25rem", "fluid": false, "slug": "x-large", "name": "Extra large" },Add some text to a post and set your font sizes (see example HTML below)
For all sizes with
"fluid": false,, the font size should be static and reflect the size value regardless of viewport width.Here, the
Extra largeheading is static:Example HTML block code
Example theme.json
{ "version": 2, "settings": { "appearanceTools": true, "layout": { "contentSize": "840px", "wideSize": "1100px" }, "typography": { "fluid": true, "fontSizes": [ { "size": ".9rem", "fluid": { "min": "0.9rem", "max": "1.1" }, "slug": "small", "name": "Small" }, { "size": "1rem", "fluid": { "min": "1rem", "max": "1.3rem" }, "slug": "medium", "name": "Medium" }, { "size": "1.75rem", "slug": "large", "name": "Large" }, { "size": "2.25rem", "fluid": false, "slug": "x-large", "name": "Extra large" }, { "size": "3.5rem", "slug": "huge", "name": "Huge" }, { "size": "4.25rem", "slug": "gigantic", "name": "Gigantic" }, { "size": "5.75rem", "slug": "colossal", "name": "Colossal" } ] } } }Check that things work in the site editor too (See #42688)
Unit tests