Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

fix fluid typography and block font sizes #109

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

madhusudhand
Copy link
Member

@madhusudhand madhusudhand commented Aug 24, 2022

This addresses the issues of fluid typography and font-sizes of few blocks.

  • Add max for small and medium to avoid max being set to a factor of 1.5 by default by Gutenberg.
  • Add an explicit fluid: false for large and x-large to bypass fluid calculation. Ref: Typography: add explicit bypass for fluid font size calculation gutenberg#42757
  • Remove the font-size for post-title block to inherit based on the set level. h2 in single post, h4 in home-page (addresses this comment)
  • Update font size of post-excerpt to match figma.

Screenshots

Home page:

Before After
image image

Single post title:

Before After
image image

Paragraphs:

Before After
image image

@carolinan
Copy link
Collaborator

carolinan commented Aug 24, 2022

With the removal of the text above the posts, the post titles on the home would be changed to h3.

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! These changes look good to me, the paragraph sizes in particular are looking really good 🎉

@pbking pbking merged commit fedbc06 into WordPress:trunk Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants