Fix Top toolbar buttons tooltips and style when 'Show button text labels' is enabled #42815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: +56 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42676
What?
Makes the Top toolbar tooltips and style consistent when the 'Show button text labels' preference is enabled.
Why?
When 'Show button text labels' is enabled:
tertiarystyle, except the 'Publish / Save' buttons. This was missed for some buttons and it was also inconsistent between the Post Editor and the Site Editor.How?
showIconLabelspreference and passes it where necessary.showIconLabelsto determine the button tertiaryvariantprop value in a consistent way across buttons and editors.Testing Instructions
Reminder: the 'Undo' and 'Redo' buttons are disabled by default. Make some changes to add undo/redo history steps and check the buttons have a tertiary style.
Screenshots or screencast
For the missing tertiary style, see screenshots on the issue #42676 (comment)