Do not show tooltip of the block toolbar buttons when text label preference is enabled. #43936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Focus] Accessibility (a11y)
|
Size Change: +72 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Note: as mentioned in #42815 buttons that are associated with a keyboard shortcut always display a tooltip, to visually expose the keyboard shortcut. This logic is in the |
afercia
force-pushed
the
fix/block-toolbar-show-icon-labels-buttons-no-tooltip
branch
from
5b201b3 to
08951b3
Compare
|
Flaky tests detected in 08951b3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4084552512
|
|
I'm going to close this PR waiting to find a better approach. |
afercia
deleted the
fix/block-toolbar-show-icon-labels-buttons-no-tooltip
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #42811
What?
This PR is a Proof Of Concept to illustrate a potential approach to address #42811
When the 'Show button text labels' preference is enabled, the block toolbar buttons show text instead of icons. However, they still display a tooltip (on hover and focus) that just repeats the visible text.
Why?
A tooltip that just repeats the visible text of the buttons is pointless and just clutters the UI. When 'Show button text labels' is enabled, the tooltip should not show, as done for the Top toolbar in #42676 / #42815
How?
For now, this PR shows a potential approach only for the 'block switcher' dropdown button, which is the first button within the block toolbar.
showIconLabelspreference value from thepreferencesStore.showIconLabelsas value to be used for theshowTooltipprop.Feedback on a couple things would be greatly appreciated. Also, any suggestions for a batter approach is very welcome. Problems I see with this approach:
preferencesStoreand add it to theblock-editorpackage? I'm not sure that is desirable.showTooltipprop needs to be explicitly set on all the buttons of the various components that are used within the block toolbar. This applies to both the post editor and the site editor. There's a lot (dozens?) of components that are used within the toolbar that would need to be changed. Is there any simpler, more generic, approach anyone can think of?Testing Instructions
Screenshots or screencast