Use useResourcePermissions in block-library and the widgets editor #43305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
the
Developer Experience
adamziel
requested review from
draganescu,
talldan,
noisysocks,
tellthemachines and
kevin940726
as code owners
|
Size Change: +691 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Aug 17, 2022
|
Code changes look good. I'm wondering what would be the best way to test changes applied, any ideas? The refined API for the use cases covered in this PR looks way better than before: const { canCreate: userCanCreatePages } = useResourcePermissions( 'pages' );The variable aliasing is still something that isn't ideal, but it could also be coded in an alternative way: const pagesPermissions = useResourcePermissions( 'pages' );
// then in the code
pagesPermissions.canCreate ? 'yes' : 'no';I guess it gives enough flexibility for start 👍🏻 |
|
@gziolo I like your suggestion and I added these names as you proposed. |
gziolo
approved these changes
Aug 19, 2022
gziolo
added
[Block] Navigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Applies the newly stabilized useResourcePermissions hook to other places in the repository.