Add __experimentalUseResourcePermissions #38785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Package] Core data
Closed
Mamaduka
reviewed
Feb 14, 2022
|
Size Change: +83 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
|
We can use this hook to replace |
gziolo
reviewed
Feb 14, 2022
adamziel
force-pushed
the
propose/use-resource-permissions
branch
from
2be93c9 to
caa48a7
Compare
kevin940726
reviewed
Feb 16, 2022
adamziel
force-pushed
the
propose/use-resource-permissions
branch
from
c86f561 to
31de2ce
Compare
kevin940726
reviewed
May 19, 2022
|
I'd like to update this PR once #41139 lands |
adamziel
force-pushed
the
propose/use-resource-permissions
branch
from
5338287 to
c1914d2
Compare
|
I fixed the unit tests, rebased this on top of trunk, and added a refactor of |
adamziel
changed the title
kevin940726
approved these changes
Jun 16, 2022
commit c86f561 Author: Adam Zieliński <adam@adamziel.com> Date: Wed Feb 16 12:17:33 2022 +0100 Move the return type to TS commit eefec13 Author: Adam Zieliński <adam@adamziel.com> Date: Wed Feb 16 12:16:36 2022 +0100 Adjust TS types commit 12c7433 Author: Adam Zieliński <adam@adamziel.com> Date: Wed Feb 16 12:13:22 2022 +0100 Make useResourcePermissions return a tuple and make hasResolved the first item of the tuple forces the users to think about that variable and it's not easy to accidentally miss it. commit caa48a7 Author: Adam Zieliński <adam@adamziel.com> Date: Tue Feb 15 17:03:31 2022 +0100 Fix typo in the tests commit 33cdb4e Author: Adam Zieliński <adam@adamziel.com> Date: Mon Feb 14 15:05:09 2022 +0100 Expose __experimentalUseResourcePermissions as a public API commit cf30c5a Author: Adam Zieliński <adam@adamziel.com> Date: Mon Feb 14 14:58:42 2022 +0100 Distinguish between global and local resoluion commit 0db7bd2 Author: Adam Zieliński <adam@adamziel.com> Date: Mon Feb 14 14:42:36 2022 +0100 Propose useResourcePermissions hook commit 2d5e270 Author: Adam Zieliński <adam@adamziel.com> Date: Mon Feb 14 14:48:09 2022 +0100 Move the status computation inside the enriched selectors commit e7ac34e Author: Adam Zieliński <adam@adamziel.com> Date: Mon Feb 14 14:01:11 2022 +0100 Propose useEntityRecords
Co-authored-by: Kai Hao <kevin830726@gmail.com>
adamziel
force-pushed
the
propose/use-resource-permissions
branch
from
44dd755 to
c1da2e3
Compare
This was referenced Aug 16, 2022
adamziel
added a commit
that referenced
this pull request
Aug 19, 2022
Originally introduced in Pull Request #38785
mburridge
added
the
Needs Dev Note
|
Added the Needs Dev Note label in case this needs a dev note (either individual or as part of a "misc" dev note) for WP 6.1 release. |
|
Dev note proposed at https://make.wordpress.org/core/?p=99829&preview=1&_ppp=2b1db975ea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a minimal subset of #38135 focused solely on the
useResourcePermissionshook.The goal of these new APIs is to lower the barrier of entry for new contributors and make the life of existing contributors easier.
Example usage:
Before
After:
It returns a tuple and with
hasResolvedthe first item so that it's intentionally too hard to overlook. Thank you @kevin940726 for this suggestion!See also how the combination of all proposed hooks makes the navigation block ~200 lines leaner.
Test plan
Other considerations
@gziolo said:
API resources are separate from entity records, we refer to them using a different set of identifiers.
You can either pass an id to this hook and get a create/update/delete permissions, or skip an id and get only the create permissions. Both are useful, e.g. in the Gutenberg codebase we sometimes do
canUser( 'update', 'settings' );and other times we docanUser( 'delete', resource, postId ).cc @kevin940726 @talldan @gziolo @draganescu @ellatrix @noisysocks @jsnajdr @getdave @Mamaduka @spencerfinnell