core-data: Fix canUser allowed methods handling
#63615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
commented
Jul 16, 2024
Comment on lines
+27
to
+29
| headers: new Headers( { | ||
| allow: 'POST', | ||
| } ), |
There was a problem hiding this comment.
Headers is the right interface for dealing with response headers. Just using the constructor adds the necessary functionality, including proper support for .get().
| @@ -419,8 +419,7 @@ export const canUser = | |||
| // Optional chaining operator is used here because the API requests don't | |||
| // return the expected result in the native version. Instead, API requests | |||
| // only return the result, without including response properties like the headers. | |||
| const allowHeader = response.headers?.get( 'allow' ); | |||
| const allowedMethods = allowHeader?.allow || allowHeader || ''; | |||
| const allowedMethods = response.headers?.get( 'allow' ) || ''; | |||
There was a problem hiding this comment.
Cleaning up as the .allow access was not necessary.
|
Size Change: -9 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jul 16, 2024
|
Interesting, so the In lodash, |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
* core-data: Fix useResourcePermissions test fixtures * core-data: Clean up canUser allowed methods Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR cleans up a wrong access for retrieving the allowed methods inside
canUser.Why?
See #63430 (comment)
Because it's not necessary and was wrong. It was introduced in #43117 and the related test that needed to be improved was added in #38785.
How?
Fixing the test fixture and removing the unnecessary object access.
Testing Instructions
Testing Instructions for Keyboard
None
Screenshots or screencast
None