-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table of contents: add spacing supports #43368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Enhancement
A suggestion for improvement.
[Feature] Design Tools
Tools that impact the appearance of blocks both to expand the number of tools and improve the experi
[Block] Table of contents (experimental)
Affects the Table of contents Block
labels
Aug 18, 2022
ramonjd
requested review from
ZebulanStanphill,
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
August 18, 2022 10:21
apeatling
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Confirm that the dimensions control panel is there
✅ Add margin and padding.
✅ Save and confirm the styles appear on the frontend.
✅ Test the new support works for the block via theme.json and global styles. See example JSON below.
packages/e2e-tests/specs/site-editor/global-styles-sidebar.test.js
Outdated
Show resolved
Hide resolved
Size Change: +3 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
…ear in the site editor block search results for the term 'header'. 'header' appears in the block.json description and is therefore a match.
ramonjd
force-pushed
the
add/table-of-contents-spacing-supports
branch
from
August 19, 2022 03:01
3ba7388
to
5948dc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Table of contents (experimental)
Affects the Table of contents Block
[Feature] Design Tools
Tools that impact the appearance of blocks both to expand the number of tools and improve the experi
Needs User Documentation
Needs new user documentation
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Enabling spacing support for the Table of contents block
Why?
To create consistency across blocks.
How?
Adding the relevant block supports in block.json
Testing Instructions
Example block code