Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table of contents: add spacing supports #43368

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Table of contents: add spacing supports #43368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee1a644
Adding spacing block supports to table of contents
ramonjd Aug 18, 2022
5948dc2
Now that the table of contents block has a block supports it will app…
ramonjd Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/reference-guides/core-blocks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,7 @@ Summarize your post with a list of headings. Add HTML anchors to Heading blocks

- **Name:** core/table-of-contents
- **Category:** layout
- **Supports:** ~~html~~
- **Supports:** spacing (margin, padding), ~~html~~
- **Attributes:** headings, onlyIncludeCurrentPage

## Tag Cloud
Expand Down
6 changes: 5 additions & 1 deletion packages/block-library/src/table-of-contents/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@
}
},
"supports": {
"html": false
"html": false,
"spacing": {
"margin": true,
"padding": true
}
},
"example": {}
}
3 changes: 2 additions & 1 deletion packages/e2e-tests/specs/site-editor/global-styles-sidebar.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ describe( 'Global styles sidebar', () => {
const results = await page.$$(
'.edit-site-block-types-item-list div[role="listitem"]'
);
expect( results.length ).toEqual( 1 );
// Matches both Heading and Table of Contents blocks. (The latter contains "heading" in its description.)
expect( results.length ).toEqual( 2 );
} );
} );
} );