TabPanel: Convert to TypeScript #43536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
commented
Aug 23, 2022
| @@ -145,7 +145,6 @@ Optionally provide a tab name for a tab to be selected upon mounting of componen | |||
| #### children | |||
|
|
|||
| A function which renders the tabviews given the selected tab. The function is passed the active tab object as an argument as defined the tabs prop. | |||
| The element to which the tooltip should anchor. | |||
| title: 'Components/TabPanel', | ||
| component: TabPanel, | ||
| parameters: { | ||
| controls: { expanded: true }, |
There was a problem hiding this comment.
I didn't expand the code snippet because it isn't very helpful if the children part isn't shown
|
Size Change: +11 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Aug 24, 2022
| ); | ||
| } | ||
| }, [ tabs ] ); | ||
|
|
||
| return ( | ||
| <div className={ className }> | ||
| <NavigableMenu | ||
| ref={ forwardedRef } |
There was a problem hiding this comment.
Curious to why the ref was added to NavigableMenu and not the wrapper div ?
I'm asking because I wonder if consumers of the package would have a way to expect, in general, what component the ref holds (since we don't even document it in our docs)
There was a problem hiding this comment.
To be honest I'm pretty unclear about ref forwarding. Most examples I find online are cases where you want to do myRef.focus(). So I kind of understood it to mean that you want to pass the ref to the main interactive element 🤔 But I really don't know. Should make a non-ref-forwarding version of WordPressComponent asap? 😅
There was a problem hiding this comment.
To be honest I'm pretty unclear about ref forwarding
Same — not sure if there's a standard around it. We should probably read about in order to make a better informed decision!
Should make a non-ref-forwarding version of WordPressComponent asap? 😅
That sounds like a good option for now. We could then avoid introducing a ref in this PR altogether, and then swap the custom instances of WordPressComponentPropsWithoutRef across the package
mirka
force-pushed
the
tabpanel-typescript
branch
from
8d968fc to
de963ba
Compare
mirka
force-pushed
the
tabpanel-typescript
branch
from
de963ba to
f1710c7
Compare
walbo
approved these changes
Sep 1, 2022
cbravobernal
added
the
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35744
In preparation for #42320
What?
Converts the TabPanel component to TypeScript.
Why?
For better documentation, devex, and code quality.
How?
Following the contributing guide.
Testing Instructions
npm run storybook:dev