Introduce experimental form & inputs blocks to allow building basic forms #44214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +22.4 kB (+1%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
aristath
force-pushed
the
form-fields
branch
2 times, most recently
from
5d66ed0 to
13279f8
Compare
aristath
force-pushed
the
form-fields
branch
2 times, most recently
from
69a9987 to
7a2325c
Compare
aristath
force-pushed
the
form-fields
branch
4 times, most recently
from
0cbb1bf to
c2dcd04
Compare
aristath
force-pushed
the
form-fields
branch
2 times, most recently
from
bbeb087 to
9aa3e3f
Compare
aristath
force-pushed
the
form-fields
branch
2 times, most recently
from
d6187d2 to
12936f3
Compare
|
Just a quick update on the current status of the forms/fields blocks:
cc @draganescu There are a few UX issues that need to be tweaked (for example selecting the form parent vs the input fields), but it is now in a working state, marked as an experiment. As an MVP I believe this can serve us well, and allow us to tweak it and improve the implementation while it's an experiment. Screen.Recording.2022-10-18.at.10.14.59.AM.mov |
aristath
changed the title
aristath
changed the title
aristath
requested review from
ryelle,
Mamaduka,
mtias,
youknowriad and
tellthemachines
aristath
added
New Block
It is an experiment because it's still under an experimental flag. The only difference now is that now it's merged and ready for testing and feedback widely, specially for those folks who missed the start of the dev process. There has been multiple experiments that never made it to the final release because during that process the feedback received reflected that the feature was not ready or not in the right state to become part of core. Just because it's merged doesn't mean that it's done. |
|
I've been following this PR since its inception because I am very interested in having these capabilities in the editor. While I'm happy it's merged, it did seem abrupt to me as well. A similar sentiment about how difficult is to track and contribute to rather large undertakings like this when they happen in single GitHub issues/PRs can be found here: #53788 (comment)
The "Experiments" screen has no indication that the features listed are available for further feedback, or where the best place to leave that feedback is. 
|
|
Ah, I understand. This PR was merged for the 16.9 milestone, meaning it will be available in the Gutenberg plugin release 16.9.that is slated for October 25th with a RC on 10/18. If you are eager to start testing you can use the Gutenberg Nightly |
|
@bph my screenshot was a general reference to the Experiments page lacking any sort of way to provide feedback for any of the listed experiments that have already been merged -- I realize my screenshot is of a version that does not yet include this additional experiment. Related |
|
Sorry for the misunderstanding. @spencerfinnell |
|
Thanks for your feedback here @spencerfinnell -- let's see what we can do to iterate. Would love your feedback here: #55174 |
This was referenced Oct 10, 2023
|
I've just tested this, and hitting submit doesn't seem to do anything? I've added an email in the form settings panel. |
|
@jamiemarsland Thank you for testing this! |
|
Adding to the comments about giving feedback: I wanted to go back to this block, read more about it and test it. Unfortunately there is no label for this experiment/block yet and searching the 5k+ issues for "forms" is pretty overwhelming and it took me a little while to find this PR😅 |
Done 👍 |
|
I am just about to create a video showing my experience of this new form block. |
|
I will pretend that this is the discussion thread as there are likely things here that are nice to discuss somewhere and add in my initial video test of the Form block. I got to say I really like what I see. I see this as a very good beginning of a helpful core Form block! |
|
Thank you for testing this @paaljoachim! The button was not working but that is already fixed in PRs #55690 and #55691 (both pending a review, so this will be fixed on trunk once these get merged). Now, regarding some other things you brought up:
|
Isn't that what the |
|
Exploring the form. I am using the default included form.
From the visual it looks like the font in the comment field is different compared to name and email fields. Clicking Submit nothing happens. I thought that was fixed and added to the Gutenberg plugin.... I am leaving it up on this page. Just another web site....not used for much at all. Kinda like a dev site. |
|
I updated to Gutenberg plugin 17.2. EDIT: |
|
@youknowriad These blocks are experimental and as @aristath said
Do you know whether the packages sync process will omit the experimental blocks from |
|
✅ I updated the PHP Sync Tracking Issue for WP 6.5 to note this PR does not require a backport for WP 6.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Introduces new
core/formandcore/form-inputblocks to allow building forms in the editor.More background on #44186 (please read that ticket for background on the concept)
Screenshots or screencast
I updated the screencast with the latest implementation (Dec.7 2022). The original screencast from the POC is no longer relevant, but can still be found here)
forms-demo.mov
NOTE: These blocks are experimental. Please go from your dashboard to Gutenberg > Experiments, and enable the "Form and input blocks" experiment. Once you do, the blocks will be available.