Site editor: 🥝 Media library proof of concept 🥝 #53788
Conversation
- media sidebar item and main page - fetching attachment records
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/media-library.php ❔ lib/load.php |
|
Size Change: +47.6 kB (+3%) Total Size: 1.56 MB
ℹ️ View Unchanged
|
…nanza' into try/site-editor-media-library-bonanza # Conflicts: # packages/edit-site/src/components/page-media/index.js
…nanza' into try/site-editor-media-library-bonanza # Conflicts: # packages/edit-site/src/components/page-media/index.js
ramonjd
added
[Type] Technical Prototype
That's correct. We have an issue on colours here and explorations are underway around how to make use of the existing theme component in wordpress/components. What we are working towards.
If we do move forward with tags as the organisational paradigm than we'll probably want to emphasise them more (e.g. move out of dropdown and in to sidebar or similar) |
ramonjd
changed the title
|
When I see the left sidebar Images, Video, Audio and Documents I just want to create subfolders below as if it was a submenu in the Navigation menu. Example adding images into a structural approach. Using folders as if these were categories. Then being able to also add tags. Using the standard post approach. Top level broad stroke with categories and going into details with tags. Images |
|
@paaljoachim you might want an image and a video to be in the same category/tag. An alternative is to show categories/tags in sidebar (like you suggest) with media type a filter in the page instead. |
|
Great work, y'all! @ramonjd @jasmussen @SaxonF
Thanks! |
|
Thanks for the questions @jeffgolenski!
I believe showing image metadata came up in discussions, and we all agreed it would be a good idea. 😄 So I believe the answer is a tentative "yes", at least it's on the wish list.
The image editing was thrown in as an afterthought so I couldn't give you a straight answer on that. The library I plucked out of the internet can handle it, though there remains the task of fully investigating the backend image manipulation already in Core. I think the benchmark, in terms of functionality, would be to offer what Core does already with the intention to build it out further. 👍🏻 |
|
Hello all. So first and foremost before I start adding some feedback to the project: I only recognize Paal's name in this thread, so allow me to introduce myself. Feedback: What I'm here for is to completely overhaul the Media Library. If you look at the comments in Matias's proposal people aren't asking for a new skin to the old Media Library, they're essentially asking for Digital Asset Manager (DAM). This is something that needs to be addressed from the ground up.
If you've used Lightroom, or Bridge, or Capture One, or an agency level DAM, you'll recognize why we're asking for these. Here's a screenshot of the Library in Lightroom for reference: And I created some mockups a few years back as a place to start when I started building some proof of concepts in JS. Mind you this was before Gutenberg, and before the editor style changing. So the design aesthetic is rather dated, but the basic ideas of something more like a DAM are there.
It's important to note these aren't what I would build now. But there are some bones in these mockups that are important. Also, I think it's imperative to have buy in, and understand the need for these changes. I know I'm walking in here like a bull into a china shop. So I understand if it's off-putting. Just know that my intentions are all about making a product that I can be proud to use when I open up my photography site and add a new post with my photos, or when an agency publishes an article and they can easily find a picture one of their staff photographers took 5 years ago with just a couple clicks. Feel free to @ me here, or find me on Twitter @WilliamBay. I'm happy to discuss anything in greater depth, and help move this project forward. |
|
I worry about adding the media library to the site editor for what it's worth. It feels out of place and hard to access. Keeping the media library as its top-level content type might be better. Media assets are more like post types than they are like design elements ( templates, template parts, patterns ). Especially if we finely add better controls that allow for organizing and filtering. I like some of the latter mockups. They look good. The secondary controls for accessing the media details or editing those details, cropping, and previewing video/audio, would be handled in a separate settings panel, similar to the content editor for block settings. Switching back and forth on the left-hand menu is tiring and time-consuming. |
|
@bahia0019 great feedback! Definitely agree this needs more thought and wider input. This is simply a POC that shows how a media library could work using @wordpress/components and some of the existing patterns in the site editor (e.g. patterns page) so please consider it just that, a POC. The site editor just gave us a space to build that POC. We do have to consider the future of admin in this work though and the site editor offers a glimpse of that. Would the Core Media team like to create a GH overview issue for a redesign media library? Slack will be great for synchronous discussions etc but for folks who are in different timezones or not part of Slack GH can be more accessible and its connected with other related projects. The overview issue will be a great place to highlight existing pain points and opportunities we've observed and gives us a space to explore different solutions. One other note is that we will want to make use of the work being done in list views which includes complex filtering, different view types (list, grid), quick editing, saved views etc |
|
Good to have these ideas, thanks, folks!
Agree, thanks @SaxonF Maybe we're just missing a tracking issue, however, for what it's worth the development side of the project hasn't — as far as I'm aware —been started in any capacity. Still, when an over-arching issue does arise we could use what's been documented here as reference.
For sure. I'm thinking it might be part of the evolution of the admin experience, brought up in https://make.wordpress.org/core/2023/07/12/admin-design/ So however the media library is implemented for the editor, there'd be shared components and view a the "top level". |
|
I'm going to close this branch. Happy to continue the discussion here for the record until there's a better place. 🙇🏻 |
Yeah, I kinda figured you were using the Site Editor to cherry pick on use the native components and UI stuff. That makes sense. I think a running proof of concept or a plugin which we can all install and play with is great. I have some stuff I've done for grid view I've worked on already I can contribute. Whether that stays here, or moves I really don't mind.
I'm not sure the best way to approach a large project like this in the WordPress workflow. I come from agency work where my PM handled all that. But a dedicated Github project where we can create tickets for all the features isn't a bad idea. Again, not sure where it fits in with the WordPress feature workflow. Perhaps some people in in the Slack channel are smarter than I am in that regard. I'm excited, and looking forward to making something cool with y'all. |
|
@ramonjd and @SaxonF If we want to think about having any meetings, I'm US Pacific time, and unemployed (I'll start looking for work at the start of the new year), so my time is super flexible right now. |
|
It'd be great to keep some momentum going, thanks for lighting the fire @bahia0019 I think we could rather keen the discussion open so that we garner as much feedback and ideas as possible. My idea would be to create a tracking issue that records your and others' ideas in https://make.wordpress.org/core/2023/07/07/media-library/, and center the enterprise around it. I think it'd be a good resource to have for planning and production, particularly if we break down tasks. This will be a big project (and an important one!) I expect, so design input and initial development will take time. It may not seem like things are moving, but some of the underlying components that this proof of concept PR experimented with are already being worked on, e.g., the sortable data table view: #55083 |
|
@ramonjd you may be interested in #55174 -- discussion around collecting feedback for experimental features. In my opinion something like what the Interactivity API is using makes sense: https://github.com/WordPress/gutenberg/discussions/categories/interactivity-api |
|
I've opened a rough tracking issue over here: I expect we can open some high level discussion threads once the scope is refined. Cheers! |
|
If you are looking for feedback... it's important to allow the user to create image taxonomies and map those to the meta-data contained in the files they upload whether that data is in exit, IPTC or XMP or else filtering will always fall short. You can see an example of how this could work here: https://github.com/photopress-dev/photopress-plugin If it's not easy to create custom taxonomies (or have them automatically created!) from embedded meta-data then filtering and searching the media library will come up short for users that need more and more elaborate filters as their media library grows... This is the core issue with the media library IMHO. |
Thanks! I've added a note on the tracking issue. |
This is an experiment only 🚧 Do not merge
2023-08-20.17.42.15.mp4
Stuff