Migrate Gallery tests to Playwright #45202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
kevin940726,
glendaviesnz,
getdave and
ntsekouras
and removed request for
ntwb,
ajitbohra and
nerrad
Mamaduka
added
[Type] Bug
|
Size Change: +1.92 kB (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
Mamaduka
changed the title
|
Odd, tests are passing for me locally without an issue. I will continue debugging on Monday. |
Mamaduka
commented
Oct 21, 2022
| const gallery = page.locator( 'role=document[name="Block: Gallery"i]' ); | ||
|
|
||
| await expect( gallery ).toBeVisible(); | ||
| await editor.selectBlocks( gallery ); |
There was a problem hiding this comment.
I had to use editor.selectBlocks() util. Selecting a Gallery block using page.click() isn't reliable, it can easily select an inner image block.
|
The tests are passing without an issues now. This is ready for the review. |
| // | ||
| // Attempts to add an Axe exception for the media modal haven't proved | ||
| // successful: | ||
| // https://github.com/WordPress/gutenberg/pull/22719 |
There was a problem hiding this comment.
I wonder of we should copy across the full details of this test so there is a record of what it was supposed to do if the Axe issue can be resolved, eg. the following seems to work locally:
test.fixme(
'when initially added the media library shows the Create Gallery view',
async ( { admin, editor, page } ) => {
await admin.createNewPost();
await editor.insertBlock( { name: 'core/gallery' } );
await page.click( 'role=button[name="Media Library"i]' );
await page.waitForSelector( '.media-frame' );
expect( await page.innerText( '.media-frame-title h1' ) ).toBe(
'Create gallery'
);
expect(
await page.innerText( '.media-toolbar-primary button' )
).toBe( 'Create a new gallery' );
}
);
There was a problem hiding this comment.
Makes sense. Done in 926c24f.
There was a problem hiding this comment.
I don't think we're still running Axe test in Playwright, which is what I missed in the first place. But this probably also means that this test should pass now that Axe is out of the way?
There was a problem hiding this comment.
I can double-check this and re-enable the test. Thanks for the info, @kevin940726.
glendaviesnz
approved these changes
Oct 25, 2022
|
Thanks for testing, @glendaviesnz 🙇 I'm going to merge this. PHP Unit failures are unrelated. See #45254. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
PR migrates Gallery
captione2e tests to Playwright.Why?
These tests started failing a lot recently. We already had a Gallery test in the Playwright suite, so I did a
partialmigration.P.S. I migrated skipped test with a
fixmemark.How?
Testing Instructions