Re-enable skipped Gallery block e2e test #45266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
kevin940726
reviewed
Oct 25, 2022
Comment on lines
208
to
214
| await expect( page.locator( '.media-frame' ) ).toBeVisible(); | ||
| await expect( page.locator( '.media-frame-title h1' ) ).toContainText( | ||
| 'Create gallery' | ||
| ); | ||
| await expect( | ||
| page.locator( '.media-toolbar-primary button' ) | ||
| ).toContainText( 'Create a new gallery' ); |
There was a problem hiding this comment.
Is it possible to refactor these selectors into role selectors?
There was a problem hiding this comment.
Sure. Initially, I thought we wanted to check that these elements have correct text, hence the toContainText usage. But we can do the same with role selectors.
Edit: Updated in 6015d51.
Mamaduka
force-pushed
the
fix/enable-skipped-gallery-test
branch
from
6015d51
to
7da8efa
Compare
|
Seems like the react native e2e tests failure is unrelated. I think we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #45202 (comment).
PR re-enables skipped Gallery block e2e tests. I've also updated the test to use locators.
Testing Instructions