Migrate/shortcut help #46179
Closed
Migrate/shortcut help #46179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorasaurus
added
the
[Type] Automated Testing
|
@Mamaduka Can you please take a look on this? |
Mamaduka
reviewed
Jun 13, 2023
There was a problem hiding this comment.
@alvitazwar, the migrated tests seem to be failing. Do you mind checking again if they run locally for you?
|
I've picked this up over in #53832. I tried pushing changes here but it didn't work 🤷. The new branch is based on this one so @alvitazwar’s commits are preserved. |
|
Closed in favor of #53832. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Based on #38570, part of #38851. Migrate shortcut-help.test.js
Why?
See #38570 for its background and rationale.
This is split into a new PR for easier review.
How?
See #38570 for the proposed migration steps.
Testing Instructions
npm run test:e2e:playwright /test/e2e/specs/editor/various/shortcut-help.spec.js
Screenshots or screencast
Screen.Recording.2022-11-30.at.4.36.37.AM.mov