Migrate shortcut help e2e tests to Playwright #53832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- swap pressKeyWithModifier for pressKeys - use locator assertions - remove some extraneous steps in latter tests - cleanup comments
stokesman
added
[Type] Automated Testing
Closed
|
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
stokesman
requested review from
kevin940726,
Mamaduka,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Thanks for picking this up, @stokesman!
Great work on combining tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Picks up from (seemingly abandoned) #46179 to complete the migration of a test suite to Playwright.
Why?
As part of #38851.
How?
According to migration steps.
Notes on differences from Puppeteer
In Puppeteer these tests all shared the same post but doing so with our Playwright test utils was not straightforward. Trying to run
admin.createNewPostfrombeforeAllresulted in:I tried working around that and ran into problems with each approach and gave up. Still as I see it not sharing the same post had two concerns:
createNewPostfor each testTo address those concerns these changes were made:
Testing Instructions