Allow adding new templates and template parts directly from the sidebar #46458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
12 tasks
|
Size Change: -306 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
add/create-template-sidebar
branch
from
b6685ec
to
4f6e407
Compare
|
Nice one:
Jay is working on edit button improvements and can hopefully share something very cool next week. But in the mean time, I think we should go with a background-less white plus, like so:
I guess it can be a tertiary style, but with a white color instead of blue. What do you think? |
|
@jasmussen wfm |
jasmussen
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Looks good!
Whether in this PR or another, I think we need to revisit the hover/active states for some of these buttons as the colors disappear:
I tend to think a simple solution is to not have any hover or active states in this dark background context. Just keep it all white. We can always revisit.
|
@jasmussen 👍 I forced the color to be always white. |
|
I noticed that the "Edit" button background inside the Template Parts navigation screen is slightly off. I'm guessing due to some kind of flexbox quirk 😄 Screenshot
|
|
Good catch! I know that @jameskoster has an idea for moving the edit button up to the top. While the design I've seen him working on has a few extra details, perhaps we can do that in the mean time? That is — place it permanently in context of the site icon/title, then on the right. One of the ideas is that the site title itself can become a bit more contextual, somewhat like a breadcrumb, giving context where at the moment some is lacking. |
|
Just for context, the ideas is a widget at the top of the navigator which morphs to display contextual actions as you navigate around: shortcuts.mp4An important element therein is the URL which would communicate what is visible in the frame. I think we probably need that connective tissue before we can move the Edit button, but hopefully it's not too much work since we don't have full browse-ability yet. We'd just need to work out the display when templates like Single, 404, etc are selected. It might be as simple as replacing the URL with the template name. |
This was referenced Jan 13, 2023
38 tasks
This was referenced Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #45100 and based on the design from #45100 (comment)
What?
This PR adds a "plus" button to the templates/template parts sidebar to allow creating them directly from there without opening the "browse all" view.
Testing Instructions