Add the template title and type to the site hub #46736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
jorgefilipecosta,
jasmussen and
jameskoster
youknowriad
commented
Dec 22, 2022
| const entityLabel = | ||
| record.type === 'wp_template_part' | ||
| ? __( 'template part' ) | ||
| : __( 'template' ); |
There was a problem hiding this comment.
There was a bug in trunk where these strings were not translated.
There was a problem hiding this comment.
Couldn't we rely o the post type labels provided by the rest API?
There was a problem hiding this comment.
These labels are only available in plural form for all users. If we can reword here to use plural that would work, but let's leave this separate and just keep the bug fix for now.
|
Nice, this is feeling solid to me. One small issue, the text remains in-editor:
I think there's an open question on whether the type or the name should be on top or below, and white or gray. I know @jameskoster has a lot of thoughts on this, and he's AFK for the moment. But I also think we can arguably launch with one set, and then revisit. Similarly, there are some margins and site logo dimensions we can polish, nothing that I think need block this. One thing that I expect we'll want to refine is eliding of text, and how that works for templates with very long titles. I think we can use |
|
Size Change: +362 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Fixed the bug and added the text ellipsis. |
|
Seems good to me! |
| const entityLabel = | ||
| record.type === 'wp_template_part' | ||
| ? __( 'template part' ) | ||
| : __( 'template' ); |
There was a problem hiding this comment.
Couldn't we rely o the post type labels provided by the rest API?
|
Good catch @jorgefilipecosta pushed a fix for the breakpoint issue. |
youknowriad
force-pushed
the
add/title-to-site-hub
branch
from
e0835ee to
9d1bdbf
Compare
jorgefilipecosta
approved these changes
Dec 23, 2022
12 tasks
24 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #46700
Related #36667
What?
This PR adds the template title and type to the site hub in the site editor to match the proposed designs.
Why?
These titles and type gives clarity about the entity that is currently being shown on the site editor frame.
How?
useEditedEntityRecordhook from the DocumentActions component and used it in the site hub to grab the title.SiteHubcomponent from theLayoutcomponent as it was getting a bit complex.Testing Instructions
1- Open the site editor
2- Navigate templates, template parts...