Fix clicking on the toggle button not closing the block inserter #47926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
|
Size Change: +8 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 57d84b9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4141987945
|
kevin940726
force-pushed
the
fix/inserter-not-closing
branch
from
6e8af48
to
06b3438
Compare
apeatling
requested changes
Feb 9, 2023
alexstine
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
@kevin940726 Thanks for the fix. This has been annoying me for some time. Glad the button toggles now.
kevin940726
commented
Feb 10, 2023
kevin940726
force-pushed
the
fix/inserter-not-closing
branch
from
b90720c
to
57d84b9
Compare
Mamaduka
approved these changes
Feb 10, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ntsekouras
dismissed
their stale review
It seems there is a consensus to land this ad hoc fix, so feel free to land..
apeatling
approved these changes
Feb 10, 2023
|
Working in the site editor now, LGTM! 👍 |
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 7c87d68 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Fix #43090.
How?
This PR takes an ad-hoc approach to fix the issue. There might be better solutions with focus handling, but it'd be nice to land this until we find a better solution.Testing Instructions
Also added an e2e test.
Testing Instructions for Keyboard
This issue is not reproducible on keyboard.
Screenshots or screencast
Kapture.2023-02-09.at.21.02.27.mp4