-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move site editor 6.2 specific code to the right file #48023
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Feb 13, 2023
ntsekouras
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Riad! Will you be able to create the trac ticket and the back port PR to core?
Actually I think this could be part of https://core.trac.wordpress.org/ticket/57631. |
Yeah, it's just two lines to remove. |
Cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Feb 14, 2023
This was referenced Feb 14, 2023
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Feb 14, 2023
…irect. Removes the server-side redirection if missing `postType` and `postId` query args when visiting Site Editor. Why? This redirect is no longer needed as the routing is now handled client side (via [55333]). References: * [WordPress/gutenberg#48023 Gutenberg PR 48023] * [WordPress/gutenberg#47777 Gutenberg PR 47777] Follow-up to [55333], [53413], [53093]. Props ntsekouras, youknowriad. Fixes #57716. git-svn-id: https://develop.svn.wordpress.org/trunk@55338 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Feb 14, 2023
…irect. Removes the server-side redirection if missing `postType` and `postId` query args when visiting Site Editor. Why? This redirect is no longer needed as the routing is now handled client side (via [55333]). References: * [WordPress/gutenberg#48023 Gutenberg PR 48023] * [WordPress/gutenberg#47777 Gutenberg PR 47777] Follow-up to [55333], [53413], [53093]. Props ntsekouras, youknowriad. Fixes #57716. Built from https://develop.svn.wordpress.org/trunk@55338 git-svn-id: http://core.svn.wordpress.org/trunk@54871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
Feb 14, 2023
…irect. Removes the server-side redirection if missing `postType` and `postId` query args when visiting Site Editor. Why? This redirect is no longer needed as the routing is now handled client side (via [55333]). References: * [WordPress/gutenberg#48023 Gutenberg PR 48023] * [WordPress/gutenberg#47777 Gutenberg PR 47777] Follow-up to [55333], [53413], [53093]. Props ntsekouras, youknowriad. Fixes #57716. Built from https://develop.svn.wordpress.org/trunk@55338 git-svn-id: https://core.svn.wordpress.org/trunk@54871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
DaisyOlsen
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
labels
Feb 14, 2023
VenusPR
added a commit
to VenusPR/Wordpress_Richard
that referenced
this pull request
Mar 9, 2023
…irect. Removes the server-side redirection if missing `postType` and `postId` query args when visiting Site Editor. Why? This redirect is no longer needed as the routing is now handled client side (via [55333]). References: * [WordPress/gutenberg#48023 Gutenberg PR 48023] * [WordPress/gutenberg#47777 Gutenberg PR 47777] Follow-up to [55333], [53413], [53093]. Props ntsekouras, youknowriad. Fixes #57716. Built from https://develop.svn.wordpress.org/trunk@55338 git-svn-id: http://core.svn.wordpress.org/trunk@54871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a small mistake in #47777 (comment) this PR just moves this file content to the 6.2 folder.