-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the WP packages with fixes prior to WP 6.2 beta 2 #4070
Conversation
src/wp-admin/site-editor.php
Outdated
); | ||
wp_safe_redirect( $redirect_url ); | ||
exit; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep this makes sense 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change part of the @wordpress
package updates? Thinking it's a separate backport.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also not seeing this change in WordPress/gutenberg@1bf01c0. Curious where and why it's being made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a back port from WordPress/gutenberg#48023, which is included in the packages update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In talking with @ntsekouras, the PHP change here is separate from the scope of updating the @wordpress
packages in Core. Nik will revert this PHP change and open a separate backport Trac ticket and PR for it. I'll get both reviewed and committed shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the commit and will open a new trac ticket for it and a separate PR
Currently reviewing. |
ecc88ec
to
dcfa98c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Package version numbers match WordPress/gutenberg@1bf01c0 ✅
- CI is passing ✅
- Local testing - no errors ✅
Ready for commit 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ntsekouras LGTM!
Committed via https://core.trac.wordpress.org/changeset/55333. |
Trac ticket: https://core.trac.wordpress.org/ticket/57471
This updated the packages to the latest versions with the latest fixes.
WordPress/gutenberg@1bf01c0
Includes the following changes:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.