Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the WP packages with fixes prior to WP 6.2 beta 2 #4070

Closed

Conversation

ntsekouras
Copy link

@ntsekouras ntsekouras commented Feb 14, 2023

Trac ticket: https://core.trac.wordpress.org/ticket/57471

This updated the packages to the latest versions with the latest fixes.

WordPress/gutenberg@1bf01c0

Includes the following changes:

  • Add missing period in keyboard shortcut descriptions
  • Site Editor: Append template type and name to the site editor page title
  • Specify active color state for template navigation button
  • Global Styles: Move more link about custom CSS to part of description
  • ToolsPanel: Display optional items when values are updated externally
  • File block: Re-add editor styles for classic themes
  • Enable undo after creating a new menu
  • Style Book: Exclude blocks that are not allowed to insert
  • Add basic tsconfig.json validation
  • Fix Experiments native variant breakage
  • Update moment and moment-timezone packages to fix timezone issues
  • NavigatorButton: Reuse Button types
  • ToolsPanel: Ensure display of optional items when panel id is null
  • ColorPalette: Ensure text label contrast checking works with CSS variables
  • Components: Add support for named arguments in the navigator components
  • Rename experiments package to private-apis
  • Cherry-pick CLI: Fix the default label to match the documentation
  • Handle block metadata attribute and related experimental APIs
  • Fix: Remove browser default border for iframe in the editor
  • [Layout]: Fix align controls for hybrid themes
  • Visual Regression tests: use default playwright utils
  • SelectControl: Fix multiple prop styling
  • Fix clicking on the toggle button not closing the block inserter
  • Update deps for the useEffect that creates navigation menus
  • Minor updates in Private APIs docs
  • Site Editor: Fix custom Template Parts rename action
  • [Block Library - Cover]: Ensure url is not malformed due to sanitization through wp_kses
  • Revert "Prevent the image from being resized larger than its container"
  • Lodash: Remove from @wordpress/keycodes package
  • Distraction free mode: Fix keyboard shortcut not working
  • Popover: lock the __experimentalPopoverPositionToPlacement function
  • Rename the "experiments" export to "privateApis"
  • Add an aria label to the site save dialog
  • Navigator: add more pattern matching tests, refine existing tests
  • Add parent navigation support for the navigator component
  • Add back link to Design heading in site editor navigation to return to Dashboard
  • Add a nested level when selecting templates or template parts
  • Move site editor 6.2 specific code to the right file
  • Fix site editor navigation

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

);
wp_safe_redirect( $redirect_url );
exit;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep this makes sense 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change part of the @wordpress package updates? Thinking it's a separate backport.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not seeing this change in WordPress/gutenberg@1bf01c0. Curious where and why it's being made.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a back port from WordPress/gutenberg#48023, which is included in the packages update.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In talking with @ntsekouras, the PHP change here is separate from the scope of updating the @wordpress packages in Core. Nik will revert this PHP change and open a separate backport Trac ticket and PR for it. I'll get both reviewed and committed shortly.

Copy link
Author

@ntsekouras ntsekouras Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the commit and will open a new trac ticket for it and a separate PR

@hellofromtonya
Copy link
Contributor

Currently reviewing.

Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for commit 👍

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ntsekouras LGTM!

@hellofromtonya
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants