Post editor: add temporary flag to disable iframe #48064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
Feb 14, 2023
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "$schema": "https://schemas.wp.org/trunk/block.json", | |||
| "apiVersion": 2, | |||
| "temporarilyDisableIframe": "I understand that this flag will only work for two releases (6.2 and 6.3) and that the block must be updated to avoid breakage in WP 6.4.", | |||
There was a problem hiding this comment.
Just added this for testing. Can't quite get it to work with the schema.
|
Size Change: +336 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 00f2e8a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4172789262
|
|
See #48076. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds a flag for blocks to use in
block.jsonto disable the iframe TEMPORARILY to give plugin authors the time to update their blocks. It will be removed after two releases.Why?
Some blocks are incompatible with the iframe: for example they use jQuery components in the block edit function which doesn't work in the iframe.
Ideally the block edit function should be a visual representation of the block and ideally it should use the components we provide. Of course you can use third party React components or non React components, but what is rendered in the iframe should be a preview/visual editing field and any UI like popovers and select boxes should be rendered outside of the iframe (for example with the Popover component).
How?
Adds a check to see if all block types are compatible.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast