Post editor: revert iframed editor for WP core only #48076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
the
Needs Dev Note
|
Size Change: +30 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Feb 14, 2023
|
Flaky tests detected in 9b16bc9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4181744359
|
Mamaduka
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Thank you, @ellatrix!
I think this is the right decision for WP 6.2 before we have a suitable compatibility mode in place.
Maybe we should publish a proposal on the make.wp.org/core blog for more feedback. What do you think.
Edit: This was meant as a comment, but using Gutenberg plugin env variable is a good direction IMO.
ellatrix
added
the
Backport to WP 6.7 Beta/RC
ellatrix
commented
Feb 15, 2023
This was referenced Feb 15, 2023
|
@ellatrix Do you think it would be possible to use the In the earlier revisions this was tied to the theme being a block based one. But I personally think if we use the Also should we create a separate issue for tracking that particular effort? |
Yes, that's exactly my plan. There's no need to limit it to block based themes if we do that. However, the number one priority right now is to revert for core. I'll follow up with the rest. I also want to investigate some other compatibility issues before we continue. |
|
Not sure what's up with the performance test. The site editor one is failing, but I didn't touch the site editor. I ran it locally and it passes. |
|
@ellatrix, it's been failing for PRs for a while now. See https://github.com/WordPress/gutenberg/actions/workflows/performance.yml?query=is%3Afailure @WunderBart, I think you found the source of the failure, correct? |
ntsekouras
pushed a commit
that referenced
this pull request
Feb 20, 2023
* Post editor: revert iframed editor for WP core only * Use env var
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 8a24a11 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
|
Hello 👋 Glad to see more time given for developers. In my case, I have a plugin [Wayfinder] that leverages the body classes to display indicators for blocks and other elements. The iframe effectively blocked those pieces of data. Hopefully when the decision to use the iframe is implemented, it will also include the body classes somewhere. Maybe as data attributes in the iframe tag? Example 👇 |
This was referenced Mar 14, 2023
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reverts the iframed post editor for WP core.
Why?
We want to give plugin authors more time to make their blocks compatible.
The best way forward seems to use the block api version to check compatibility. For the next release, we will iframe the post editor only if all blocks in the library are api version 3 or higher.
How?
Checks the
IS_GUTENBERG_PLUGINconstant which is not present in WP core.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast