Add Nav block files to those triggering error for exhaustive deps #48821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Code Quality
|
Size Change: +20 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fcfcff8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4352425804
|
|
Seeking a confidence check here that this only enables for Nav block files. I think this is a pattern we could employ until we have eliminated all |
tyxla
approved these changes
Mar 7, 2023
| // Components package. | ||
| 'packages/components/src/**/*.[tj]s?(x)', | ||
| // Navigaiton block. | ||
| 'packages/block-library/src/navigation/**/*.[tj]s?(x)', |
There was a problem hiding this comment.
👍 I think it's a good call to expand this list as we work through addressing the existing warnings and aim to not introduce new ones.
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
With the merge of #24914 and #48680 this PR ups the level of the exhaustive deps rule to
errorfor the Navigation block.Why?
There have been far too many bugs caused by humans missing deps. This rule will force avoiding any future regressions.
How?
Add the Nav block files to the exceptions setting exhaustive deps eslint rule to
erroras opposed to the defaultwarning.Testing Instructions
useEffectin the Nav blockindex.jsfile and remove some of the dependencies from the deps array.errorstatus (not justwarning).Testing Instructions for Keyboard
Screenshots or screencast