Remove actions from SidebarNavigationScreenWrapper #48935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -162 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
The PR tests well, and the + icon is indeed removed. However, now I don't know if this is the best approach if users can still edit menu items using the three dots icon on each item. I think if we are going to remove the + icons, we might need to also remove all link editing functionality from the Navigation panel. 🤔
|
priethor
added
[Type] Bug
|
This makes sense to me. To me it makes more sense to switch the new and manage actions for all panels: |
priethor
removed
the
Backport to WP 6.7 Beta/RC
|
Just tested with this PR and while it does properly remove the inserter (nicely done), I agree that we should also limit what can be done to each item as Nick points out above. Of note, there are more issues found here including lack of clarity around which menu is shown #48897, an overstretched view of a menu item with extra characters in the URL, and a strange UX/copy when there's no navigation items in place: navigation.browse.mode.mov |
|
This is not related to this PR specifically, but I just ran into another issue around submenus in the Navigation Panel. See the video below. This strengthens my suggestion to remove all editing functionality for 6.2. It can and should stay in Gutenberg for further iteration, but I am concerned about 6.2. submenu-issues.mov |
priethor
added
Backport to WP 6.7 Beta/RC
|
jorgefilipecosta
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
The code changes look good to me and work as advertised. The inserter is removed from the sidebar navigation as expected.
After this, PR is backported in 6.2. We should add the inserter back in the Gutenberg plugin and decide what type of inserter we want. If we want to show a block list normally or automatically insert page links like I'm proposing at #48745.
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 9708fc4 |
Mamaduka
removed
the
Backport to WP 6.7 Beta/RC
|
For me in custom-link-sidebar-nav.mp4 |
|
This PR just removes the + from the top — reducing the flow of adding a link, then not being able to customize it. If you add the link elsewhere (i.e. off canvas) then you customize it when you add. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The current flow of editing existing navigation items within the Site Editor sidebar navigation has a number of rough edges, as indicated in these issues: #48675, #48593, #48612, #48741
We don't have time to refine those further before the WordPress 6.2 release, but we can reduce the likelihood of friction by temporality removing the ability to add new blocks to the navigation (from the sidebar view).
How?
Removes the actions passed in the SidebarNavigationScreenWrapper.
Testing Instructions
Screenshots or screencast
Before:
After: