-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Story for the full global styles UI. #49031
Conversation
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
15405d9
to
4daab94
Compare
Flaky tests detected in b3f7977. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4503515195
|
4daab94
to
1e0f3fc
Compare
👋 Heads up: We will be adding some additional config so we can better isolate stylesheet dependencies (#49099). If your PR merges first, could you let me know if this |
#49099 just got merged, so there's likely a need to rebase and rewrite some config to make this PR work |
1e0f3fc
to
b3f7977
Compare
Thank you for the heads up. This PR was updated taking into account the latest changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The storybook config part looks good!
I trust that the Storybook example itself is working as expected at the moment.
This PR adds a story for the full global styles UI.
With the work starting at #49014 to move the styles editor to the browse mode sidebar, we need to make sure the global styles UI and the underlying components work well on a dark background.
There is a large amount of work required to make the components look good on dark background and it will require multiple interactions.
In order to make it possible to test the underlying global styles UI components in "dark mode", a story provides an easy UI to do it.
This PR adds a story for the entire global styles UI.
Sreenshot
Testing
Execute
npm run storybook:dev
.Verify there is "Global Styles UI" story inside the edit site package in the story book.
Verify it is possible to use the component without any crashes.