Fix: Global styles forces a white background. #49042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
Size Change: +89 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
jorgefilipecosta
deleted the
fix/global-styles-forces-a-white-background
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the main global styles component containers are setting a white background and dark text color. This is unexpected when the UI is covered on a dark background like the navigation sidebar. The containers should not be opinionated and should inherit their colors.
This PR fixes the issue.
Testing
Cherry pick this commit on the branch of this PR #49031.
Set the story Global Styles Ui to dark.
Verify the background of the global styles sidebar is dark and not white (without this PR, it stays white).