-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Revert "Disable block's touchable component when is focused" #49951
Merged
fluiddot
merged 1 commit into
trunk
from
revert-49691-rnmobile/fix/disable-block-touchable-when-focused
Apr 20, 2023
Merged
[RNMobile] Revert "Disable block's touchable component when is focused" #49951
fluiddot
merged 1 commit into
trunk
from
revert-49691-rnmobile/fix/disable-block-touchable-when-focused
Apr 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
the
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
label
Apr 20, 2023
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
geriux
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
fluiddot
deleted the
revert-49691-rnmobile/fix/disable-block-touchable-when-focused
branch
April 20, 2023 10:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reverts #49691.
Why?
The PR revert is needed to fix a regression related to removing the ability to select the parent block of container blocks.
How?
Reverting the code introduced in #49691.
Testing Instructions
Blocks can be selected
Inner blocks can be selected
N/A
Parent block can be selected
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A