Post Title: improve preview on the editor site #50147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Block] Post Title
gigitux
force-pushed
the
add/48963-display-post-type-name-as-preview
branch
from
d2309b1 to
5d7e75f
Compare
gigitux
requested review from
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
gigitux
force-pushed
the
add/48963-display-post-type-name-as-preview
branch
from
5d7e75f to
7112bee
Compare
ntsekouras
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Thanks @gigitux! Code wise this looks good and @jasmussen has agreed with this approach. I'd really love one more opinion though probably by @mtias 😄
|
Let's give it a try |
|
I'm very happy to see this change 😁 Though I must say it now feels a little inconsistent to see the 'Post' prefixes on other blocks. It might be neat to try renaming those too as originally suggested in #26856. |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* rename post-title to title and update labels * fix E2E test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR improves the preview of the block on the editor.
Fixes #48963
Why?
Currently, in the editor, the preview of the Post Title is hard-coded, and it is
Post Title. Making the preview would improve the user experience.There is a similar issue for the
Post Excerptblock #48964. Also, this PR could be part of this macro issue #49108.How?
The PR renames the block to
Titleand updates the label to make it more generic.Testing Instructions
Titleblock.Screenshots or screencast