Post Excerpt: improve preview on the editor site

[gigitux]

What?

This PR improves the preview of the block on the editor.

Fixes #48964

Why?

Currently, in the editor, the preview of the Post Excerpt is hard-coded, and it is:

This is the Post Excerpt block, it will display the excerpt from single posts.

If there are any Custom Post Types with support for excerpts, the Post Excerpt block can display the excerpts of those entries as well.

Making the block title and labels more generic would improve the user experience:

This block will display the excerpt.

There is a similar issue for the Post Title block #48963. Also, this PR could be part of this macro issue #49108.

How?

The PR renames the block to Excerpt and updates the labels to make it more generic.

Testing Instructions

1. Edit a template (Single Post, for example).
2. Add the Excerpt block.
3. Ensure the preview is generic and can work for other postType templates.

Screenshots or screencast

[swissspidy]

Assembling the string like this will not work for many languages other than English, so this should be avoided. Please consult the polyglots team on this!

I highly recommend rephrasing the sentences to avoid this issues, or add these to get_post_type_labels() in core.

[carolinan]

I don't believe this is the correct solution, because the text must be fully translatable.
@SergeyBiryukov when convenient could you help review the code and remind us about the difficulties with translating the post type?
I will leave this link for reference: https://core.trac.wordpress.org/ticket/52047

I think a better solution that we could also use for other blocks is to use a more generic description without the post type.
Simply "Excerpt" instead of "Page excerpt" "Post excerpt".

[gigitux]

I think a better solution that we could also use for other blocks is to use a more generic description without the post type. Simply "Excerpt" instead of "Page excerpt" "Post excerpt".

Good point! Thinking about it, this would be the easiest way to fix the issue. We could do the same for #48963

[nerrad]

I think a better solution that we could also use for other blocks is to use a more generic description without the post type.
Simply "Excerpt" instead of "Page excerpt" "Post excerpt".

Agree! Generic does seem the best route here. "Title" vs "Post Title", "Excerpt" vs "Post Excerpt" etc.

[ntsekouras]

I think a better solution that we could also use for other blocks is to use a more generic description without the post type.
Simply "Excerpt" instead of "Page excerpt" "Post excerpt".

This seems like a good solution probably. Any thoughts on this @mtias, @jasmussen @jameskoster ?

[carolinan]

Would "Excerpt" work for WooCommerce @nerrad?

[jasmussen]

Agree, simple and generic works well here.

[gigitux]

Thanks for your precious feedback! I make the labels more generic as well with f3a30376df53a55dd5bdfa7558ebd254e1ae049c. What do you think?

[gigitux]

Would "Excerpt" work for WooCommerce @nerrad?

Even if it wouldn't be the best fit, we can update the name and description of the block with a variation (as we are already doing). The main issue was the labels in the edit file that we can't control.

[nerrad]

Would "Excerpt" work for WooCommerce @nerrad?

Even if it wouldn't be the best fit, we can update the name and description of the block with a variation (as we are already doing). The main issue was the labels in the edit file that we can't control.

This. I think conceptually it also works well across the breadth of different post types that might be used on a given WordPress site (or WooCommerce store). The presence of "Post" nomenclature for all these post types was the most pressing issue here.

[mtias]

should this be "the" excerpt?

[mtias]

There's an inconsistent use of "the excerpt" and "an excerpt" that would be good to address

[gigitux]

There's an inconsistent use of "the excerpt" and "an excerpt" that would be good to address

Thanks for the review! Fixed with 80d6a4d and d288bb5.

[nerrad]

Changes look good. I also did a double-check through the codebase to see if there are any other instances of the string that could be updated and didn't find any so looks like you got them all.