(e2e)(template-parts) Add E2E test for editing the title of a new custom template part #50195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +834 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
kevin940726
reviewed
May 2, 2023
test/e2e/specs/editor/various/post-editor-template-mode.spec.js
Outdated
Show resolved
Hide resolved
test/e2e/specs/editor/various/post-editor-template-mode.spec.js
Outdated
Show resolved
Hide resolved
test/e2e/specs/editor/various/post-editor-template-mode.spec.js
Outdated
Show resolved
Hide resolved
test/e2e/specs/editor/various/post-editor-template-mode.spec.js
Outdated
Show resolved
Hide resolved
test/e2e/specs/editor/various/post-editor-template-mode.spec.js
Outdated
Show resolved
Hide resolved
tyxla
reviewed
May 2, 2023
There was a problem hiding this comment.
Thanks for adding a test @fullofcaffeine!
I have little to add on top of @kevin940726's extensive review.
test/e2e/specs/editor/various/post-editor-template-mode.spec.js
Outdated
Show resolved
Hide resolved
|
Thanks for the review, folks! I'll look into the comments today and add the suggested fixes 👍🏻 |
fullofcaffeine
force-pushed
the
add/regression-test-for-edit-post-template-title
branch
from
50ad3e6
to
50cb4a1
Compare
fullofcaffeine
force-pushed
the
add/regression-test-for-edit-post-template-title
branch
from
50cb4a1
to
c3808a3
Compare
kevin940726
approved these changes
May 4, 2023
test/e2e/specs/editor/various/post-editor-template-mode.spec.js
Outdated
Show resolved
Hide resolved
tyxla
approved these changes
May 4, 2023
fullofcaffeine
deleted the
add/regression-test-for-edit-post-template-title
branch
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a (regression) E2E test for editing the title of a new custom template part. Regress-test the bug that was found and fixed here: #49984 by @jsnajdr.
Why?
A bug was introduced in 15.6 and was not found until after the plugin was released. This specific scenario wasn't being tested.
How?
By creating a new custom template part of a post then editing its name, and making sure the name changes in the title button, after the edit dialog closes.
Testing Instructions
All E2E tests should pass.