Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(e2e)(template-parts) Add E2E test for editing the title of a new custom template part #50195

Merged
merged 5 commits into from
May 4, 2023
Merged

(e2e)(template-parts) Add E2E test for editing the title of a new custom template part #50195

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d7513f8
Add (regression) E2E test for editing the title of a new custom templ…
fullofcaffeine Apr 28, 2023
2949a25
Small formatting improvement
fullofcaffeine Apr 28, 2023
dbb2c46
Add jsdoc to the `editTemplateTitle` helper function
fullofcaffeine Apr 28, 2023
c3808a3
Add improvements after code review
fullofcaffeine May 4, 2023
776ab21
Remove activateTheme call, it is not needed
fullofcaffeine May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions test/e2e/specs/editor/various/post-editor-template-mode.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,32 @@ test.describe( 'Post Editor Template mode', () => {
).toBeVisible();
} );

test( 'Allow editing the title of a new custom template', async ( {
page,
postEditorTemplateMode,
} ) => {
async function editTemplateTitle( newTitle ) {
await page
.getByRole( 'button', { name: 'Template Options' } )
.click();

await page
.getByRole( 'textbox', { name: 'Title' } )
.fill( newTitle );

const editorContent = page.getByLabel( 'Editor Content' );
await editorContent.click();
}

await postEditorTemplateMode.createPostAndSaveDraft();
await postEditorTemplateMode.createNewTemplate( 'Foobar' );
await editTemplateTitle( 'Barfoo' );
fullofcaffeine marked this conversation as resolved.
Show resolved Hide resolved

await expect(
page.getByRole( 'button', { name: 'Template Options' } )
).toHaveText( 'Barfoo' );
} );

test.describe( 'Delete Post Template Confirmation Dialog', () => {
test.beforeAll( async ( { requestUtils } ) => {
await requestUtils.activateTheme( 'twentytwentyone' );
Expand Down