Lodash: Replace _.mergeWith() with deepmerge in blocks
#50637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Status] In Progress
tyxla
changed the title
_.mergeWith() with deepmerge in blocks
tyxla
changed the title
_.mergeWith() with deepmerge in blocks_.mergeWith() with deepmerge in blocks
|
Size Change: +553 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
tyxla
force-pushed
the
try/lodash-merge-with-deepmerge
branch
from
da7097c
to
4c5b3c3
Compare
tyxla
force-pushed
the
try/lodash-merge-with-deepmerge
branch
from
4c5b3c3
to
fe8a518
Compare
|
Flaky tests detected in fe8a518. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5245002795
|
|
This should be ready for a review now. |
tyxla
requested review from
jorgefilipecosta,
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
flootr,
chad1008,
ntsekouras and
fabiankaegy
tyxla
added
[Feature] Paste
and removed
[Status] In Progress
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.mergeWith()fromgetBlockContentSchemaFromTransforms().Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using
deepmergeas a replacement as we've done in other places already.Testing Instructions