Lodash: Refactor away from _.mergeWith()
#51483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
gziolo,
swissspidy,
flootr,
chad1008,
ntsekouras and
fabiankaegy
|
Size Change: +589 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Jun 14, 2023
|
Thank you for taking a look, @ntsekouras 🙌 |
tyxla
force-pushed
the
remove/lodash-merge-with
branch
from
9be4f52
to
4cc273d
Compare
tyxla
removed
the
[Status] Blocked
tyxla
force-pushed
the
remove/lodash-merge-with
branch
from
4cc273d
to
b4ef294
Compare
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Lodash: Refactor away from _.mergeWith() * Add back the comment * Update package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the last usage of Lodash's
_.mergeWith()and deprecates the function.Blocked by #50637 and should be rebased after it lands.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
Just like we've been doing in other places, we're replacing
_.mergeWith()with thedeepmergepackage.To ensure we're not merging arrays, we're adding a
isMergeableObject: isPlainObjectsetting that will only merge objects and fully override arrays to preserve the pre-existing behavior.Testing Instructions