Smaller external link icon. #50728
Merged
Smaller external link icon. #50728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -124 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
I wonder if it looks a little small now, in the context of the whole set? 
The problem with the current icon seems to be how far the arrow portion pokes out of the 16x16 square. An alternative would be to tweak it's position slightly:
|
|
That may be a better interim fix. Did you scale it down or just move it? And how does it look in context of the document actions on the right? You can try here as a quick fix. |
|
It is a good idea to make it a little smaller. As comparing the external link to the desktop preview icon is an obvious size difference. I do wonder... There is the external link icon in the Post Editor and in the Templates there is the View button. Should the View button in the site editor be switched with the External preview icon? |
|
I redrew the whole icon based on the metrics in others like Here's how it looks in the top bar: 
And the View menu @paaljoachim mentioned: 
|
|
That seems like a safer starting point. Feel free to push to this branch, or open a new that I can green light, happy to close this one in favor of another. |
jameskoster
added
the
Needs Figma Update
|
Pushed 👍 |
|
Thank you. But I can't green check my own 🙈 — but you have my blessing to give this one a green check :) |
mirka
approved these changes
May 18, 2023
|
Looks ace. |
westonruter
added a commit
that referenced
this pull request
May 19, 2023
…dd/static-closures * 'trunk' of https://github.com/WordPress/gutenberg: (26 commits) Add transparent outline to input control BackdropUI focus style. (#50772) Added wrapper element for RichText in File block (#50607) Remove the experimental flag of the command center (#50781) Update the document title in the site editor to open the command center (#50369) Remove `unwrap` from transforms and add `ungroup` to more blocks (#50385) Add new experimental version of DropdownMenu (#49473) Force display of in custom css input boxes to LTR (#50768) Polish experimental navigation block (#50670) Support negation operator in selectors in the Interactivity API (#50732) Minor updates to theme.json schema pages (#50742) $revisions_controller is not used. Let's delete it. (#50763) Remove OffCanvasEditor (#50705) Mobile - E2E test - Update code to use the new navigateUp helper (#50736) Try: Smaller external link icon (#50728) Block Editor: Remove unused 'useIsDimensionsSupportValid' method (#50735) Fix flaky media inserter drag-and-dropping e2e test (#50740) docs: Fix change log typo (#50737) Edit Site: Fix `useEditedEntityRecord()` loading state (#50730) Fix labelling, description, and focus style of the block transform to pattern previews (#50577) Fix Global Styles sidebar block selection on zoom out mode (#50708) ...
bph
added
[Type] Bug
cbravobernal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The external link icon is a little bit imbalanced in its default state, especially now that it's used as a "View post" link:
This PR updates the footprint to be better balanced in the context of other similar icons:
Note that the external link icon is also used in smaller size in some cases, when it's inside text. Because of the smaller footprint, this becomes a little smaller still with this PR:
I'm wondering if we should have a separate icon designed for in-text usage? Alternately we can change the default values from 1em to 1.5em:
Testing Instructions
Publish a post and observe the view post link after.