Fix flaky media inserter drag-and-dropping e2e test #50740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
kevin940726
approved these changes
May 18, 2023
There was a problem hiding this comment.
Thanks for the PR! Code LGTM 👍!
It still bugs me why sometimes the inserter stays open though 🤔 . After dropping the image, the inserter should close, that's a feature I believe. I'm afraid that it might be an actual bug. Or maybe it's just that Playwright sometimes runs too fast before waiting for the inserter to be closed? Maybe we can add a waiting assertion and see if it fixes the issue. If it doesn't, I agree we can just land this and try to find a solution afterward.
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
|
@kevin940726, if you try that process manually, the inserter stays open. At least, that's what happens for media drag-and-drop. It gets closed when drag-and-dropping the block because the newly inserted block gets the focus.
I think we should add the keep the check in any case. Seems logical when dealing with toggle buttons. ScreenshotCleanShot.2023-05-18.at.17.40.40.mp4 |
westonruter
added a commit
that referenced
this pull request
May 19, 2023
…dd/static-closures * 'trunk' of https://github.com/WordPress/gutenberg: (26 commits) Add transparent outline to input control BackdropUI focus style. (#50772) Added wrapper element for RichText in File block (#50607) Remove the experimental flag of the command center (#50781) Update the document title in the site editor to open the command center (#50369) Remove `unwrap` from transforms and add `ungroup` to more blocks (#50385) Add new experimental version of DropdownMenu (#49473) Force display of in custom css input boxes to LTR (#50768) Polish experimental navigation block (#50670) Support negation operator in selectors in the Interactivity API (#50732) Minor updates to theme.json schema pages (#50742) $revisions_controller is not used. Let's delete it. (#50763) Remove OffCanvasEditor (#50705) Mobile - E2E test - Update code to use the new navigateUp helper (#50736) Try: Smaller external link icon (#50728) Block Editor: Remove unused 'useIsDimensionsSupportValid' method (#50735) Fix flaky media inserter drag-and-dropping e2e test (#50740) docs: Fix change log typo (#50737) Edit Site: Fix `useEditedEntityRecord()` loading state (#50730) Fix labelling, description, and focus style of the block transform to pattern previews (#50577) Fix Global Styles sidebar block selection on zoom out mode (#50708) ...
|
@Mamaduka Oops, yep! You're right! I was mistaken 🙈. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #50325.
PR fixes flaky "can be replaced by dragging-and-dropping images from the inserter" e2e test.
Why?
A consecutive call to
openMediaTabwill close the block inserter if it's open, and block library locators will fail. The first test assertion closes the inserter sometimes and allows the test to pass.The test trace from this run can be used to confirm my theory - https://github.com/WordPress/gutenberg/actions/runs/5013447893.
How?
I adjust the logic in
openMediaTabto avoid accidentally closing the inserter.Testing Instructions
openMediaTabcall below the first one.