ListView: Converted additional content render into a Component #51163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
Size Change: +19 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c18fca2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5143666568
|
andrewserong
reviewed
Jun 2, 2023
There was a problem hiding this comment.
Thanks for picking this one up @Mamaduka, this is exactly the direction I was imagining for converting the render function prop to a component 👍
Happy to give it a proper test once this is ready for review!
|
Thank you, @andrewserong! I did more testing, and I think PR is ready for review. |
andrewserong
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Thanks for following up @Mamaduka, this is testing well, code looks good, and I like the simplified names for some of the consts, too 👍
LGTM! ✨
|
Thanks for review, @andrewserong! |
|
Thank you 🙇 🙇 🙇 |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #50827.
PR updates the
ListViewto use a component for rendering additional block UI instead of a render callback.Why?
MainContentis rerendered.How?
renderAdditionalBlockUItoadditionalBlockContentand treat it like a component.renderLinkUIfunction into a new component.Testing Instructions
Screenshots or screencast