Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] should open correct Global Styles panel when example is clicked #50839

Closed
github-actions bot opened this issue May 22, 2023 · 2 comments · Fixed by #51365
Closed

[Flaky Test] should open correct Global Styles panel when example is clicked #50839

github-actions bot opened this issue May 22, 2023 · 2 comments · Fixed by #51365
Labels
[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented May 22, 2023

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

should open correct Global Styles panel when example is clicked

Test path

/test/e2e/specs/site-editor/style-book.spec.js

Errors

[2023-05-22T10:55:41.919Z] Test passed after 1 failed attempt on trunk.
[2023-05-22T14:18:12.219Z] Test passed after 1 failed attempt on trunk.
[2023-05-22T15:17:40.509Z] Test passed after 1 failed attempt on fix/registered-fonts-for-site-editor-only.
[2023-05-22T16:03:37.746Z] Test passed after 1 failed attempt on update/tooltip-appearance.
[2023-05-23T00:53:23.300Z] Test passed after 1 failed attempt on try/list-view-drop-zone-allow-passing-in-a-drop-zone-ref.
[2023-05-23T01:33:04.718Z] Test passed after 1 failed attempt on try/list-view-drop-zone-allow-passing-in-a-drop-zone-ref.
[2023-05-23T02:52:24.946Z] Test passed after 1 failed attempt on add/tabpanel-listview.
[2023-05-23T03:56:26.032Z] Test passed after 1 failed attempt on add/tabpanel-listview.
[2023-05-23T04:35:13.193Z] Test passed after 1 failed attempt on add/tabpanel-listview.
[2023-05-23T13:14:12.317Z] Test passed after 1 failed attempt on trunk.
[2023-05-23T14:56:54.726Z] Test passed after 1 failed attempt on add/test-coverage-for-comments-template-block-context.
[2023-05-23T15:13:53.331Z] Test passed after 1 failed attempt on try/navigation-menu-focus-mode-experiment.
[2023-05-23T22:47:32.605Z] Test passed after 1 failed attempt on fix/wp-env-windows-start.
[2023-05-24T15:14:03.533Z] Test passed after 1 failed attempt on trunk.
[2023-05-24T17:16:59.556Z] Test passed after 1 failed attempt on docs/gutenberg-release.
[2023-05-25T05:30:19.221Z] Test passed after 1 failed attempt on update/file-spacing-support.
[2023-05-25T11:35:54.073Z] Test passed after 1 failed attempt on fix/iframe-writing-flow-tab.
[2023-05-25T14:25:49.617Z] Test passed after 1 failed attempt on fix/iframe-writing-flow-tab.
[2023-05-25T16:38:51.630Z] Test passed after 1 failed attempt on experiment/remove-interactivity-api-experimental-flag.
[2023-05-26T02:33:01.863Z] Test passed after 1 failed attempt on add/template-post-context-switching.
[2023-05-26T04:35:36.738Z] Test passed after 1 failed attempt on add/add-new-page.
[2023-05-26T04:47:26.175Z] Test passed after 1 failed attempt on trunk.
[2023-05-26T14:11:53.177Z] Test passed after 1 failed attempt on trunk.
[2023-05-26T17:52:14.930Z] Test passed after 1 failed attempt on interactivity.
[2023-05-29T02:09:26.650Z] Test passed after 1 failed attempt on add/dynamic-templates.
[2023-05-29T10:19:38.111Z] Test passed after 1 failed attempt on fix/undo-redo.
[2023-05-29T16:46:41.237Z] Test passed after 1 failed attempt on trunk.
[2023-05-30T09:17:59.429Z] Test passed after 1 failed attempt on trunk.
[2023-05-30T09:38:10.024Z] Test passed after 1 failed attempt on fix/navigation-block-aria-expanded-on-hover.
[2023-05-30T14:32:15.981Z] Test passed after 1 failed attempt on add/remove-all-notices.
[2023-05-30T14:34:32.193Z] Test passed after 1 failed attempt on rnmobile/add-columns-test.
[2023-05-30T16:13:13.036Z] Test passed after 1 failed attempt on trunk.
[2023-05-31T04:43:20.104Z] Test passed after 1 failed attempt on try/site-editor-library.
[2023-05-31T16:19:25.090Z] Test passed after 1 failed attempt on trunk.
[2023-05-31T17:31:56.027Z] Test passed after 1 failed attempt on fix/customize-widgets-fixed-toolbar.
[2023-06-01T06:19:03.115Z] Test passed after 1 failed attempt on rnmobile/release_1.96.1.
[2023-06-01T06:59:06.930Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T08:14:34.257Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T08:43:20.923Z] Test passed after 1 failed attempt on use/raw-attribute.
[2023-06-01T09:08:05.630Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T09:33:07.118Z] Test passed after 1 failed attempt on use/raw-attribute.
[2023-06-01T09:53:36.125Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T11:51:53.730Z] Test passed after 1 failed attempt on try/additional-block-contents-component.
[2023-06-01T12:02:35.461Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T15:51:27.166Z] Test passed after 1 failed attempt on update/eager-map-private-selectors.
[2023-06-01T16:26:31.587Z] Test passed after 1 failed attempt on fix/fonts-api/src-absolute-uris.
[2023-06-01T16:27:07.445Z] Test passed after 1 failed attempt on update/data-selector-binding.
[2023-06-01T21:00:43.814Z] Test passed after 1 failed attempt on add/distraction-free-to-site-editor.
[2023-06-02T02:23:07.295Z] Test passed after 1 failed attempt on trunk.
[2023-06-02T04:43:32.950Z] Test passed after 1 failed attempt on trunk.
[2023-06-02T10:17:19.522Z] Test passed after 1 failed attempt on bump-stylelint-config-recommended-packages.
[2023-06-02T13:13:25.384Z] Test passed after 1 failed attempt on update/data-selector-binding.
[2023-06-02T13:57:50.595Z] Test passed after 1 failed attempt on browse-mode-navigation-options.
[2023-06-06T01:19:28.800Z] Test passed after 1 failed attempt on try/site-editor-library.
[2023-06-06T13:32:41.923Z] Test passed after 1 failed attempt on update/behaviors-to-block-supports.
[2023-06-06T23:10:21.782Z] Test passed after 1 failed attempt on update/theme-json-schema-behaviors.
[2023-06-07T06:50:24.214Z] Test passed after 1 failed attempt on try/template-block.
[2023-06-07T07:15:11.366Z] Test passed after 1 failed attempt on feat/block-controls-fill-components-context.
[2023-06-07T11:46:13.789Z] Test passed after 1 failed attempt on refactor/playwright-performance-tests.
[2023-06-07T18:46:34.814Z] Test passed after 1 failed attempt on trunk.
[2023-06-08T05:57:12.609Z] Test passed after 1 failed attempt on trunk.
[2023-06-08T09:45:27.929Z] Test passed after 1 failed attempt on trunk.
[2023-06-08T14:35:34.420Z] Test passed after 1 failed attempt on add/categories-list-type.
[2023-06-08T18:32:33.838Z] Test passed after 2 failed attempts on rnmobile/upgrade/react-native-0.71.8.
[2023-06-08T19:33:42.597Z] Test passed after 1 failed attempt on feat/toggle-group-control-framer-motion-shared-layout.
[2023-06-08T20:41:03.526Z] Test passed after 1 failed attempt on tweak/linkcontrol-suggestions.
[2023-06-08T20:56:57.067Z] Test passed after 1 failed attempt on try/link-control-show-suggestions-on-dirty.
[2023-06-08T22:26:23.090Z] Test passed after 1 failed attempt on rnmobile/docs/fix-broken-links.
[2023-06-09T03:58:51.756Z] Test passed after 1 failed attempt on trunk.
[2024-01-28T16:37:57.796Z] Test passed after 1 failed attempt on try/optimise-get-global-block-count.
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label May 22, 2023
github-actions bot referenced this issue May 22, 2023
* Remove Add Submenu option

* Remove Link UI entirely
github-actions bot referenced this issue May 23, 2023
…ollow single responsibility principle (#50266)

* Introduce prepend_to_selector() method to avoid additional if checks and follow single responsibility principle.

* Don't call append_to_selector() when selector is likely empty.

* Remove parameter completely instead of deprecating.

* Correct doc block.
github-actions bot referenced this issue May 26, 2023
…y in Firefox (#50540)

* Can't type space if a contenteditable element is inside button/summary in Firefox

commit

* Continue event processing only if within a specific element
github-actions bot referenced this issue May 30, 2023
* Reinstate Text control outside of settings

* change selector on tests

* fix playwright test

* fix the waitForFunction function on the tests

* fix e2e tests

---------

Co-authored-by: MaggieCabrera <maggie.cabrera@automattic.com>
github-actions bot referenced this issue Jun 2, 2023
)

- Prevent DefaultAppender from appearing in a disabled block.
- Disable selection (using user-select: none) in disabled blocks.
- Prevent blocks from being inserted into a disabled block via global inserter.
- Prevent disabled blocks from being removed via keyboard shortcut.
- Prevent disabled blocks from being moved via List View drag and drop.
- Prevent block overlay from appearing on a disabled block.
github-actions bot referenced this issue Jun 2, 2023
* Add static column number option

* Address feedback and fix Group placeholder

* Revert non-responsive option

* Try using grid layout in Post Template

* Update Post Template to use auto-fill columns

* Add block spacing to post template

* Show gap control by default

* Add unstable columns grid property

* Rename layout column attribute.

* Add a media query to reproduce current responsiveness

* Move layout controls to Post Template block

* Reduce max columns to 6.

* Remove unstable prefix

* fix cols breaking out of container

* Try adding deprecation

* Fix broken loop

* Update fixtures

* Code improvements

* Add some comments to the CSS.

* Add back deleted line

* Remove legacy attributes in deprecation

* Fix deprecation logic

* Update fixtures

* Fallback gap for classic themes

* fix spacing

* match old default value

* Update PHP test strings.

* Fix tag discrepancy in fixtures
github-actions bot referenced this issue Jun 8, 2023
* Navigation: Fix ListView deprecation notice

* Unlock component at the file level
github-actions bot referenced this issue Jun 8, 2023
…owns (#51154)

* DropdownMenu: read variant from context

* Toolbar: do not set `variant` prop on popover (rely on context system instead)

* Use named export for better storybook doc generation

* Provide context value in more toolbar components

* Hook Dropdown into context system, update DropdownMenu and CircularOptionPicker

* Remove toolbar variant popover prop where the context system can be used instead

* Add comment where the context system currently doesn't work

* Use placement prop instead of legacy "position" prop

* Add some temporary TODO comments

* Set toolbar variant for Dropdown in the context system

* Remove explicit variant prop from block alignment matrix control

* Toolbar: Only set context in the top-level component

* Remove `toolbar` variant from instances using `Dropdown`

* Simplify Dropdown implementation

* Tidy up types

* Remove toolbar variant storybook example for Popover

* CHANGELOG

* Complete renaming internal type

* Remove duplicate hardcoded classnames(already added by context connexct)
@kevin940726
Copy link
Member

All of the style book related tests have been pretty flaky recently. It might be introduced in #50566 where sometimes playwright runs faster than the useEffect resetting the value.

Copy link
Author

This issue has gone 15 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Feb 13, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant