Merge selector-binding code (except resolvers) into a new bindSelector function #51176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -10 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in cbf35aa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5146430407
|
tyxla
reviewed
Jun 2, 2023
Comment on lines
+204
to
+209
| const boundSelector = ( ...args ) => { | ||
| const state = store.__unstableOriginalGetState(); | ||
| return selector( state.root, ...args ); | ||
| }; | ||
| boundSelector.hasResolver = false; | ||
| return boundSelector; |
There was a problem hiding this comment.
Given that this part is the same as bindMetadataSelector(), the only difference being where the selector reads state from, I wonder if we could further abstract this fragment into a separate function that receives the state tree name. Then we could reuse that in both bindSelector and bindMetadataSelector.
There was a problem hiding this comment.
I originally did this, if you look at the implementation in #51051, there are calls bindSelector( 'root' ) and bindSelector( 'metadata' ).
But now I plan to diverge the two versions even more. The metadata selectors only need the binding, we cal remove the hasResolver part. And when binding the classic selector, I would like to try merging the resolver fulfillment also into bindSelector. So that there is only one wrapper and when in debugger, you step into a call like:
registry.select( 'core/block-editor' ).getBlocks();you are just one step away from the actual implementation of getBlocks. Until recently, you'd have to step through several layers of wrappers.
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart of #51161, which did a similar refactor for actions. This one is for selectors.
The
mapSelectorsfunction is removed in favor of callingmapValues( selectors, bindSelector )directly. And in the private selector proxy, we map only the one selector that the getter is requesting, not all of them.This will be useful in #51051 to create stable selector references returned from
registry.select.Also, after this PR a selector (without a resolver) is mapped just once to produce the result returned by
registry.select. That makes selectors better debuggable, when stepping into selectors, we get into the implementation code faster, with less wrapper boilerplate.