Private actions and selectors: return stable references, expose to thunks #51051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +77 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6f85e3e940ed98adaa46d6b83bfee03aa9e66d19. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5200297799
|
|
Adding one more private selectors patch to this branch: in #50985 @noisysocks demonstrates a bug with private registry selectors by adding a failing test. I cherry-picked the tests to this PR and commited a fix on top. |
|
@jsnajdr would you separate the two changes into two PRs? That would make this one easier to review |
noisysocks
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
These changes and new the tests look good to me.
Our automated tests cover this code pretty well so that they pass is a fairly good indication that we can be confident of these changes.
I created a test branch containing this branch and #50857 and was able to confirm that my original problem (not being able to call a private createRegistrySelector selector from a public selector in the block-editor store) was fixed once I switched the order of registerPrivateActions and register.
I think we should move to an atomic API like the one described in #50985 (comment) so that reordering isn't necessary but this is good enough for now.
This was referenced Jun 1, 2023
jsnajdr
force-pushed
the
update/eager-map-private-selectors
branch
from
f49fad0
to
5082b05
Compare
jsnajdr
force-pushed
the
update/eager-map-private-selectors
branch
from
5082b05
to
6f85e3e
Compare
jsnajdr
force-pushed
the
update/eager-map-private-selectors
branch
from
6f85e3e
to
3aa08c6
Compare
|
@jsnajdr: Are you still planning on splitting this up or can we land this? |
There are still three fixes in one:
But all the code changes are concentrated at one place and should be easy to review. So let's review and land this PR as one. |
This was referenced Jul 2, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…unks (WordPress#51051) * Return stable references to private selectors and actions * Expose unlocked private actions and selectors to thunks * Add tests for private registry selectors, including one failing test * Fix comment typo in createRegistrySelector * Private registry selectors test: register selectors before store instantiation * Pre-bind private selectors so that registry selectors are bound to registry --------- Co-authored-by: Robert Anderson <robert@noisysocks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves two problems with private actions and selectors:
const { setFoo } = unlock( useDispatch() )always returns the samesetFooon each call, and analogously also foruseSelect. This wasn't true before, as the private actions and selectors were re-bound on each call of thedispatchgetter. Action references are sometimes used as effect dependencies, with possibly disastrous consequences if they are not constant.dispatchandselectobjects (proxies) to thunks. Thunks are considered private code of the store, and should have access to all private APIs.The PR contains a larger exploratory refactor of how the actions and selectors are bound to the store, best to review commit by commit.