Data: fix a bug where private selectors on a store with resolvers are inaccessible #51166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Bug
|
Size Change: +2 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Jun 1, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug with private selectors and resolvers:
resolversoptionunlock( registry.select( store ) )throws a "object was not locked before" errorThat's because the
createReduxStorecode first creates theselectorsobject, then locks it withlock( selectors ), and then, if resolvers are configured, doesselectors = mapValues( selectors, addResolvers ).That means
registry.selectdoesn't return the locked object, but the result ofmapValues. The originally locked object is garbage collected.I'm adding a unit test, and a fix that merely swaps the order of "lock" and "map resolvers" operations.
Discovered when working on #51051. 🙂