[Mobile] - Fix crash when switching to the HTML Editor #51650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t was focused on a block since it was calling clearSelectedBlock twice.
geriux
added
[Status] In Progress
dcalhoun
reviewed
Jun 19, 2023
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
|
Flaky tests detected in dbb3fe0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5311893734
|
dcalhoun
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Thanks for fixing this so quickly, and the test! The test plan succeeded for me on an iPhone 14 Pro simulator and a Samsung Galaxy S20 5G FE.
My understanding is that commit uncovering this issue, 1c4bd99, has not yet shipped in a mobile release. So, we do not need to ship this fix in a beta or hot fix. 👍🏻
Thank you for reviewing and testing! 🙇
That's correct, this change was merged back on June 8th, and the last commit in the |
geriux
removed
the
Mobile App - Automation
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Mobile - HTML Editor - Fix an issue where the editor would crash if it was focused on a block since it was calling clearSelectedBlock twice. * Mobile - Editor test - Update test to use toBeVisible instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRS:
What?
This PR fixes a regression after #51051 was merged.
Why?
Within
toggleModewe were callingclearSelectedBlockbut this is already being called within switchEditorMode.It appears that now that we have stable references from #51051 it surfaced this issue when it tries to clear a block when it was already cleared.
How?
By removing the extra
clearSelectedBlock. It also introduces an integration test to make sure we test the HTML editor opens.Testing Instructions
CI checks should pass in this PR and in the Gutenberg mobile PR.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
Bug.mov
BugAfter.mov