-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Block Library - Post Terms]: Custom taxonomies do not show icons when transforming from the toolbar. #51476
[Block Library - Post Terms]: Custom taxonomies do not show icons when transforming from the toolbar. #51476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This PR makes sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
The unit test is failing, but this PR should not be the cause because it is just failing to start Docker. I will try running it again later. |
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
68a123f
to
11f2663
Compare
@t-hamano |
…n transforming from the toolbar. (WordPress#51476) * fix/post-terms-variations-transforms-icon * Update packages/block-library/src/post-terms/hooks.js Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> --------- Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
What?
Custom taxonomies do not show icons when transforming from toolbar in post terms block.
Testing Instructions
Screenshots or screencast
trunk
trunk.mp4
this branch
this-branch.mp4