Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Block Library - Post Terms]: Custom taxonomies do not show icons when transforming from the toolbar. #51476

Merged

Conversation

shimotmk
Copy link
Contributor

What?

Custom taxonomies do not show icons when transforming from toolbar in post terms block.

Testing Instructions

  1. Create a custom taxonomy
  2. Insert a post terms Block.
  3. Do a transform from the toolbar. At that time, confirm that the icon is set in the custom taxonomy.

Screenshots or screencast

trunk

trunk.mp4

this branch

this-branch.mp4

@shimotmk shimotmk requested a review from ajitbohra as a code owner June 14, 2023 03:08
@t-hamano t-hamano added [Feature] Block Variations Block variations, including introducing new variations and variations as a feature [Block] Post Terms Affects the Post Terms Block labels Jun 14, 2023
@t-hamano t-hamano self-requested a review June 14, 2023 15:35
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This PR makes sense to me.

packages/block-library/src/post-terms/hooks.js Outdated Show resolved Hide resolved
@t-hamano t-hamano self-requested a review June 15, 2023 01:03
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano
Copy link
Contributor

The unit test is failing, but this PR should not be the cause because it is just failing to start Docker. I will try running it again later.

@t-hamano
Copy link
Contributor

@shimotmk

The unit test failure appears to have been resolved by #51513. Can you rebase this PR with the latest trunk?

shimotmk and others added 2 commits June 15, 2023 14:20
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
@shimotmk shimotmk force-pushed the fix/post-terms-variations-transforms-icon branch from 68a123f to 11f2663 Compare June 15, 2023 05:21
@shimotmk
Copy link
Contributor Author

@t-hamano
Thank you! Rebased PR.

@t-hamano t-hamano merged commit a40d6df into WordPress:trunk Jun 15, 2023
@github-actions github-actions bot added this to the Gutenberg 16.1 milestone Jun 15, 2023
@shimotmk shimotmk deleted the fix/post-terms-variations-transforms-icon branch June 15, 2023 06:38
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
…n transforming from the toolbar. (WordPress#51476)

* fix/post-terms-variations-transforms-icon

* Update packages/block-library/src/post-terms/hooks.js

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>

---------

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Terms Affects the Post Terms Block [Feature] Block Variations Block variations, including introducing new variations and variations as a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants