wp-env: try to fix failing PHP Github actions #51513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
andrewserong
added
[Type] Build Tooling
andrewserong
requested review from
noahtallen,
ObliviousHarmony and
t-hamano
as code owners
andrewserong
requested review from
noisysocks,
talldan,
apeatling,
ramonjd and
tellthemachines
andrewserong
changed the title
ramonjd
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
This unblocks the CI for now until something else comes along. Thanks @andrewserong 🙇
|
Flaky tests detected in b3a9d6b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5273874074
|
|
Thanks for reviewing @ramonjd! Now that this is merged to unblock |
This was referenced Jun 15, 2023
1 task
|
Is it possible to release a patch for |
Ahhh that would make sense. @ObliviousHarmony, since the |
Great question. I'm not too sure how fixes get rolled out to npm packages (and I likely don't have access to it). I'll just ping @WordPress/gutenberg-core in case anyone knows or can help out there. |
|
I believe package releases routinely happen at the same time as Gutenberg plugin releases (usually every two weeks on a Wednesday). It looks like there's a process for an individual package bugfix release: I don't personally have any experience of it. |
This was referenced Jun 16, 2023
noahtallen
pushed a commit
that referenced
this pull request
Jun 17, 2023
* wp-env: try to fix failing php 8.2 github action * Add git
|
@Luehrsen, I just updated |
7 tasks
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* wp-env: try to fix failing php 8.2 github action * Add git
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Try to fix failing PHP Github actions by attempting to resolve an error during
wp-envsetup.I noticed that the error claims that
/etc/apt/sources.listdoes not exist. This is a naive PR, but I thought I'd try adding atouchcommand to ensure the file exists. This is the error:After adding the
touchcommand, I noticed that it was complaining thatgitwasn't available, so I've added that in, too.Why?
Currently all PHP Github actions appear to be failing. This PR attempts to get them working again, in a naive way.
I'm not too sure the exact cause of the errors occurring, but it looks like the official WordPress docker images were recently updated (e.g. WordPress 8.2 image) and are now based on
debian:12-slim. Debian 12 (bookworm) was released about five days ago, so I imagine it's connected to that.How?
touchcommand to ensure that/etc/apt/sources.listexists.gitas otherwise the composer command failed.Testing Instructions
See if PHP actions will pass.
Testing Instructions for Keyboard
Screenshots or screencast