This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Temporarily skip PHP Unit Tests for PHP 8.1 and 8.2 #9859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -12 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
kmanijak
added
skip-changelog
kmanijak
changed the title
woocommercebot
requested review from
a team and
gigitux
and removed request for
a team
Closed
4 tasks
albarin
approved these changes
Jun 16, 2023
This was referenced Jun 16, 2023
thealexandrelara
pushed a commit
that referenced
this pull request
Jun 23, 2023
* Allow failure of the PHP Unit Tests * Limit the PHP versions to 7.4 and 8.0 to run unit tests * Don't allow failing fast * Add a comment explaining the skipped part * Cancel jobs later * Cancel all the steps in workflow based on the same condition
thealexandrelara
added a commit
that referenced
this pull request
Jun 23, 2023
* Empty commit for release pull request * Add back filter blocks frontend scripts (#9954) * Update changelog and bump version to 10.4.4 * Add testing notes for 10.4.4 release * Update testing notes for release 10.4.4 * Replace Automated tests badge with Unit and E2E tests badge * Wait for cart to be removed when emptied (#9829) * Temporarily skip PHP Unit Tests for PHP 8.1 and 8.2 (#9859) * Allow failure of the PHP Unit Tests * Limit the PHP versions to 7.4 and 8.0 to run unit tests * Don't allow failing fast * Add a comment explaining the skipped part * Cancel jobs later * Cancel all the steps in workflow based on the same condition --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> Co-authored-by: Alexandre Lara <allexandrelara@gmail.com> Co-authored-by: Mike Jolley <mike.jolley@me.com> Co-authored-by: Karol Manijak <karol.manijak@automattic.com>
dinhtungdu
added a commit
that referenced
this pull request
Aug 31, 2023
This reverts commit 70fd52a.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, PHP Unit Tests jobs are failing on every PR. This is most likely due the official WordPress docker images being recently updated (e.g. WordPress 8.2 image) and are now based on debian:12-slim.
That change affected multiple repositories, Gutenberg included. The WordPress/gutenberg#51513 was provided to the @wordpress/env package that unblocks the pipelines for Gutenberg's trunk, but the change is not released yet, hence we cannot update wp-env and have no control over docker-image to apply the changes manually.
Having said that, this PR limits the PHP Unit Tests to only PHP 7.4 and 8.0 which are working fine. Versions 8.1 and 8.2 are skipped until
wp-envpatch is released containing the fix: check a discussion.User Facing Testing