Lodash: Refactor away from _.set() in getNodesWithSettings()
#52278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
flootr,
jorgefilipecosta,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
|
Size Change: -5 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
tyxla
commented
Jul 4, 2023
| PRESET_METADATA.forEach( ( { path } ) => { | ||
| const value = get( treeToPickFrom, path, false ); | ||
| if ( value !== false ) { | ||
| set( presets, path, value ); | ||
| presets = setImmutably( presets, path, value ); |
There was a problem hiding this comment.
Pretty straightforward to trace - presets is already declared to be an object, and path is already an array of strings (see PRESET_METADATA declaration).
We needed to add support for arrays in order to properly work with root and nested arrays.
|
Flaky tests detected in d491d6e56e45ca86800be67cd00504a0d43c8234. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5454375786
|
tyxla
force-pushed
the
refactor/use-global-styles-output-set-lodash
branch
from
d491d6e
to
6f36e49
Compare
tyxla
force-pushed
the
refactor/use-global-styles-output-set-lodash
branch
from
6f36e49
to
0e44ec1
Compare
|
Ready for a review after #52280 landed. |
This was referenced Jul 7, 2023
Mamaduka
approved these changes
Jul 7, 2023
aristath
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.set()from thegetNodesWithSettings()global styles function.We have a few more usages of
set()left in the codebase, but we might have to tread carefully, since some of them may have to deal with Unicode characters, and I prefer testing them one by one.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're replacing the usage with the existing
setImmutablyutility function, which should do the job even better - there's no need to specifically mutate, as long as we preserve all the prior changes.Testing Instructions