Lodash: Refactor away from _.set() in PushChangesToGlobalStylesControl
#52404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
scruffian,
sgomes,
aristath,
jsnajdr,
swissspidy,
ramonjd,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
|
Size Change: +80 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f9d5dc565f027ee40934f4c8764a24fa5d651c70. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5484348128
|
Mamaduka
requested changes
Jul 7, 2023
Comment on lines
151
to
196
| setImmutably( newBlockStyles, path, undefined ); | ||
| setImmutably( | ||
| newUserConfig, | ||
| [ 'styles', 'blocks', name, ...path ], | ||
| value | ||
| ); |
There was a problem hiding this comment.
Unless I'm missing something, this shouldn't work. Unlike lodash#set, our helper returns a new object instead of updating the passed argument.
I think return values should be assigned as new config values.
There was a problem hiding this comment.
Yup, you're right.
I'm actually looking at this and it seems that the intention was to mutate the original object. Will have to address it in a different way to keep the mutation.
There was a problem hiding this comment.
@Mamaduka if you have a chance, take a look at the latest implementation.
We're duplicating setNestedValue and I'm going to follow-up with deduplicating it afterward.
tyxla
force-pushed
the
refactor/lodash-set-push-to-global-styles
branch
from
f9d5dc5
to
88de895
Compare
tyxla
force-pushed
the
refactor/lodash-set-push-to-global-styles
branch
from
88de895
to
5e5723b
Compare
Mamaduka
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.set()from thePushChangesToGlobalStylesControlcomponent.With #52278 and #52279, this removes the last occurrence of
_.set()!Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're replacing the usage with the existing
setNestedValueutility function, which we're temporarily duplicating.Testing Instructions
The typography, spacing, dimensions, and color changes you made should now apply to all blocks of that type. You can verify this by navigating to Global Styles → Blocks → "Your Block".