[RNMobile] Fix crash related to removing a block under certain conditions #52595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When determining if the block is groupable/ungroupable, we now avoid passing an undefined value which leads to a crash.
fluiddot
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
geriux
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
LGTM! 🚀 The web editor also has some checks around this in:
Where it checks a value for clientIds that is not null. I checked that useConvertToGroupButtonProps works fine with either passing null or an empty array.
So it makes sense we do the same to avoid these crashes.
fluiddot
added a commit
that referenced
this pull request
Jul 13, 2023
…#52595) When determining if the block is groupable/ungroupable, we now avoid passing an undefined value which leads to a crash.
4 tasks
westonruter
added a commit
that referenced
this pull request
Jul 13, 2023
…dd/defer-script-loading-strategy * 'trunk' of https://github.com/WordPress/gutenberg: (24 commits) Add filter to turn off Interactivity API for a block (#52579) Search: Remove unnecessary useEffect (#52604) Navigation: Simplify the useSelect for useNavigationMenus (#51977) Item: Unify focus style and add default font styles (#52495) Update Changelog for 16.2.1 Bump plugin version to 16.2.1 Avoid passing undefined `selectedBlockClientId` in `BlockActionsMenu` (#52595) Cover Block: Fix block deprecation when fixed background is enabled (#51612) Nav block: link text color inheritance fixes and tests (#51710) Stabilize defaultBlock, directInsert API's and getDirectInsertBlock selector (#52083) Fix console warning by improving error handling in Nav block classic menu conversion (#52591) Fix: Remove link action of Link UI for draft pages created from Nav block does not correctly remove link. (#52415) Lodash: Remove remaining `_.get()` from block editor and deprecate (#52561) Fix importing classic menus (#52573) ResizableFrame: Make keyboard accessible (#52443) Site Editor: Fix navigation menu sidebar actions order and label (#52592) correct a typo: sapce -> space (#52578) Avoid errors in Dimension visualizers when switching between iframed and non-iframed editors (#52588) Patterns: Add client side pagination to patterns list (#52538) Site Editor: Make sidebar back button go *back* instead of *up* if possible (#52456) ...
fluiddot
added a commit
that referenced
this pull request
Jul 14, 2023
* Release script: Update react-native-editor version to 1.99.0 * Release script: Update with changes from 'npm run core preios' * Update `react-native-editor` changelog * Release script: Update react-native-editor version to 1.99.1 * Release script: Update with changes from 'npm run core preios' * Avoid passing undefined `selectedBlockClientId` in `BlockActionsMenu` (#52595) When determining if the block is groupable/ungroupable, we now avoid passing an undefined value which leads to a crash. * Update `react-native-editor` changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a crash produced when removing a block under certain conditions. The crash was originally identified when removing a File block in a post/page with only that block. However, it has also been able to reproduce when detaching a synced pattern in a post with other blocks.
Why?
Fixes the crash wordpress-mobile/gutenberg-mobile#5925.
How?
When determining if the block is groupable/ungroupable, we now avoid passing an
undefinedvalue which leads to a crash. We now check ifselectedBlockClientIdis defined, and based on that it passes an empty array when callinguseConvertToGroupButtonProps.I was curious about why this only happens in specific blocks and noticed the following:
BlockActionsMenucomponent can be re-rendered after the block is removed but before the default Paragraph block is inserted.Removing File block:
BlockActionsMenucomponent is only re-rendered after the default block is inserted.Removing Image block:
For some reason, on specific blocks, the Redux state updates after removing the block are causing a re-render in
BlockActionsMenucomponent. I checked the parameters of both Redux actionsREMOVE_BLOCKSandEDIT_ENTITY_RECORD(this one is triggered by the block removal), but there's no specific value that differs from removing other blocks 🤔.Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
Simulator.Screen.Recording.-.iPhone.14.-.2023-07-13.at.13.32.01.mp4
Simulator.Screen.Recording.-.iPhone.14.-.2023-07-13.at.13.31.24.mp4